Skip to content

Commit

Permalink
Create fallback HTML file when prerendering is disabled (#4443)
Browse files Browse the repository at this point in the history
* Create fallback HTML file when prerendering is disabled

* Update .changeset/sour-roses-admire.md

Co-authored-by: Rich Harris <hello@rich-harris.dev>
  • Loading branch information
dimfeld and Rich-Harris authored Mar 31, 2022
1 parent 586d9be commit 8884538
Show file tree
Hide file tree
Showing 2 changed files with 22 additions and 17 deletions.
5 changes: 5 additions & 0 deletions .changeset/sour-roses-admire.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
'@sveltejs/kit': patch
---

Create fallback page when prerendering is disabled
34 changes: 17 additions & 17 deletions packages/kit/src/core/build/prerender/prerender.js
Original file line number Diff line number Diff line change
Expand Up @@ -55,10 +55,6 @@ export async function prerender({ config, entries, files, log }) {
paths: []
};

if (!config.kit.prerender.enabled) {
return prerendered;
}

installFetch();

const server_root = join(config.kit.outDir, 'output');
Expand All @@ -75,6 +71,23 @@ export async function prerender({ config, entries, files, log }) {

const server = new Server(manifest);

const rendered = await server.respond(new Request('http://sveltekit-prerender/[fallback]'), {
getClientAddress,
prerender: {
fallback: true,
default: false,
dependencies: new Map()
}
});

const file = `${config.kit.outDir}/output/prerendered/fallback.html`;
mkdirp(dirname(file));
writeFileSync(file, await rendered.text());

if (!config.kit.prerender.enabled) {
return prerendered;
}

const error = normalise_error_handler(log, config.kit.prerender.onError);

const q = queue(config.kit.prerender.concurrency);
Expand Down Expand Up @@ -268,19 +281,6 @@ export async function prerender({ config, entries, files, log }) {
await q.done();
}

const rendered = await server.respond(new Request('http://sveltekit-prerender/[fallback]'), {
getClientAddress,
prerender: {
fallback: true,
default: false,
dependencies: new Map()
}
});

const file = `${config.kit.outDir}/output/prerendered/fallback.html`;
mkdirp(dirname(file));
writeFileSync(file, await rendered.text());

return prerendered;
}

Expand Down

0 comments on commit 8884538

Please sign in to comment.