remove redundant env (#5614)

* remove redundant env

* changeset

* add meatier description

* huh, cant use those in comments, they get replaced dangerously

.changeset/thick-chicken-applaud.md

@@ -0,0 +1,5 @@
+---
+'@sveltejs/kit': patch
+---
+
+[breaking] remove mode, prod and server from \$app/env

packages/kit/src/runtime/app/env.js

@@ -1,28 +1,11 @@
-/* global __SVELTEKIT_BUILD__ */
-
 /**
  * @type {import('$app/env').browser}
  */
 export const browser = !import.meta.env.SSR;
 
-/**
- * @type {import('$app/env').server}
- */
-export const server = !!import.meta.env.SSR;
-
 /**
  * @type {import('$app/env').dev}
  */
-export const dev = !__SVELTEKIT_BUILD__;
-
-/**
- * @type {import('$app/env').prod}
- */
-export const prod = __SVELTEKIT_BUILD__;
-
-/**
- * @type {import('$app/env').mode}
- */
-export const mode = import.meta.env.MODE;
+export const dev = __SVELTEKIT_DEV__;
 
 export { prerendering } from '../env.js';

packages/kit/src/vite/build/utils.js

@@ -110,7 +110,7 @@ export const get_default_config = function ({ config, input, ssr, outDir }) {
 			__SVELTEKIT_APP_VERSION__: JSON.stringify(config.kit.version.name),
 			__SVELTEKIT_APP_VERSION_FILE__: JSON.stringify(`${config.kit.appDir}/version.json`),
 			__SVELTEKIT_APP_VERSION_POLL_INTERVAL__: JSON.stringify(config.kit.version.pollInterval),
-			__SVELTEKIT_BUILD__: 'true'
+			__SVELTEKIT_DEV__: 'false'
 		},
 		// prevent Vite copying the contents of `config.kit.files.assets`,
 		// if it happens to be 'public' instead of 'static'

packages/kit/src/vite/index.js

@@ -206,7 +206,7 @@ function kit() {
 					}
 				},
 				define: {
-					__SVELTEKIT_BUILD__: 'false',
+					__SVELTEKIT_DEV__: 'true',
 					__SVELTEKIT_APP_VERSION_POLL_INTERVAL__: '0'
 				},
 				resolve: {

packages/kit/test/apps/options/source/pages/mode/index.svelte

@@ -1,12 +1,10 @@
 <script>
-	import { dev, mode as mode_from_import } from '$app/env';
+	import { dev } from '$app/env';
 
 	/** @type {string} */
 	export let mode_from_endpoint;
 </script>
 
 <h2>
-	{mode_from_endpoint} === {mode_from_import} === {import.meta.env.MODE} === {dev
-		? 'development'
-		: 'custom'}
+	{mode_from_endpoint} === {import.meta.env.MODE} === {dev ? 'development' : 'custom'}
 </h2>

packages/kit/test/apps/options/test/test.js

@@ -209,6 +209,6 @@ test.describe('Vite options', () => {
 		await page.goto('/path-base/mode');
 
 		const mode = process.env.DEV ? 'development' : 'custom';
-		expect(await page.textContent('h2')).toBe(`${mode} === ${mode} === ${mode} === ${mode}`);
+		expect(await page.textContent('h2')).toBe(`${mode} === ${mode} === ${mode}`);
 	});
 });

packages/kit/types/ambient.d.ts

@@ -65,7 +65,7 @@ declare namespace App {
 
 /**
  * ```ts
- * import { browser, dev, mode, prerendering, prod, server } from '$app/env';
+ * import { browser, dev, prerendering } from '$app/env';
  * ```
  */
 declare module '$app/env' {
@@ -75,31 +75,14 @@ declare module '$app/env' {
 	export const browser: boolean;
 
 	/**
-	 * `true` in development mode, `false` in production.
+	 * Whether the dev server is running. This is not guaranteed to correspond to `NODE_ENV` or `MODE`.
 	 */
 	export const dev: boolean;
 
-	/**
-	 * The Vite.js mode the app is running in. Configure in [`vite.config.js`](https://vitejs.dev/config/shared-options.html#mode).
-	 * Vite.js loads the dotenv file associated with the provided mode, `.env.[mode]` or `.env.[mode].local`.
-	 * By default, `vite dev` runs with `mode=development` and `vite build` runs with `mode=production`.
-	 */
-	export const mode: string;
-
 	/**
 	 * `true` when prerendering, `false` otherwise.
 	 */
 	export const prerendering: boolean;
-
-	/**
-	 * `true` in production mode, `false` in development.
-	 */
-	export const prod: boolean;
-
-	/**
-	 * `true` if the app is running on the server.
-	 */
-	export const server: boolean;
 }
 
 /**

packages/kit/types/internal.d.ts

@@ -323,5 +323,5 @@ declare global {
 	const __SVELTEKIT_APP_VERSION__: string;
 	const __SVELTEKIT_APP_VERSION_FILE__: string;
 	const __SVELTEKIT_APP_VERSION_POLL_INTERVAL__: number;
-	const __SVELTEKIT_BUILD__: boolean;
+	const __SVELTEKIT_DEV__: boolean;
 }