feat: adapter-static throws buildtime error when `!config.kit.prere…

…nder.default && !adapter.fallback` (#5562) * feat: adapter-static errors with incorrect config * changeset * fix: Update caught incorrectly configured test project * rename disabled test to fallback * Update packages/adapter-static/index.js * lockfile Co-authored-by: Rich Harris <hello@rich-harris.dev>
sveltejs · Jul 16, 2022 · ff2ca89 · ff2ca89
1 parent 2e9d8fb
commit ff2ca89
Show file tree

Hide file tree

Showing 10 changed files with 9 additions and 4 deletions.
diff --git a/.changeset/eleven-buckets-deny.md b/.changeset/eleven-buckets-deny.md
@@ -0,0 +1,5 @@
+---
+'@sveltejs/adapter-static': patch
+---
+
+[breaking] Throws when correctly configured to run as a static site of a SPA
diff --git a/packages/adapter-static/index.js b/packages/adapter-static/index.js
@@ -14,8 +14,8 @@ export default function (options) {
 
 		async adapt(builder) {
 			if (!options?.fallback && !builder.config.kit.prerender.default) {
-				builder.log.warn(
-					'You should set `config.kit.prerender.default` to `true` if no fallback is specified'
+				throw Error(
+					'adapter-static requires `config.kit.prerender.default` to be `true` unless you set the `fallback: true` option to create a single-page app. See https://github.com/sveltejs/kit/tree/master/packages/adapter-static#spa-mode for more information'
 				);
 			}
 

diff --git a/...t/test/prerendering/disabled/package.json → ...t/test/prerendering/fallback/package.json b/...t/test/prerendering/disabled/package.json → ...t/test/prerendering/fallback/package.json
diff --git a/...t/test/prerendering/disabled/src/app.html → ...t/test/prerendering/fallback/src/app.html b/...t/test/prerendering/disabled/src/app.html → ...t/test/prerendering/fallback/src/app.html
diff --git a/...t/test/prerendering/disabled/src/hooks.js → ...t/test/prerendering/fallback/src/hooks.js b/...t/test/prerendering/disabled/src/hooks.js → ...t/test/prerendering/fallback/src/hooks.js
diff --git a/...endering/disabled/src/routes/index.svelte → ...endering/fallback/src/routes/index.svelte b/...endering/disabled/src/routes/index.svelte → ...endering/fallback/src/routes/index.svelte
diff --git a/...st/prerendering/disabled/svelte.config.js → ...st/prerendering/fallback/svelte.config.js b/...st/prerendering/disabled/svelte.config.js → ...st/prerendering/fallback/svelte.config.js
@@ -3,7 +3,7 @@ import adapter from '../../../../adapter-static/index.js';
 /** @type {import('@sveltejs/kit').Config} */
 const config = {
 	kit: {
-		adapter: adapter(),
+		adapter: adapter({ fallback: '200.html' }),
 
 		prerender: {
 			enabled: false

diff --git a/.../test/prerendering/disabled/tsconfig.json → .../test/prerendering/fallback/tsconfig.json b/.../test/prerendering/disabled/tsconfig.json → .../test/prerendering/fallback/tsconfig.json
diff --git a/...test/prerendering/disabled/vite.config.js → ...test/prerendering/fallback/vite.config.js b/...test/prerendering/disabled/vite.config.js → ...test/prerendering/fallback/vite.config.js
diff --git a/pnpm-lock.yaml b/pnpm-lock.yaml