Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

centralise eslint/ts/prettier config #1

Closed
Rich-Harris opened this issue Oct 15, 2020 · 0 comments
Closed

centralise eslint/ts/prettier config #1

Rich-Harris opened this issue Oct 15, 2020 · 0 comments
Labels

Comments

@Rich-Harris
Copy link
Member

No description provided.

@benmccann benmccann mentioned this issue Nov 21, 2020
Rich-Harris added a commit that referenced this issue Mar 1, 2021
* WIP vite prod builds

* prettier

* HN example working, at least

* fix some stuff

* update config files

* various

* simplify

* simplify

* oops

* fix find_layout

* remove logging

* fix vite base path

* make vite a peer dependency

* let vite serve static assets

* get SSR CSS working

* remove unused code

* rename CLI

* simplify configs

* tweak relationship between different packages

* simplify app-utils

* update tests to remove app startup crashes in prod

* fix lockfile

* tweak some file locations etc, get some more tests passing

* get tests passing

* update lockfile

* update lockfile

* get all tests passing, locally at least

* remove snowpack-related stuff

* add vite-plugin-svelte to monorepo

* lint

* dont remove styles, it breaks stuff. TODO investigate

* Upgrade vite

* fix some sourcemap stuff

* remove vite-plugin-svelte from workspace until things settle down more

* fix lockfile

* gloss over import.meta transform bug for now

* hack around vite bugs until 2.0.4

* only lint src files

* remove source-map-support, it was causing weird stuff to happen

* ensure renderer waits for layout/error styles

* i really dont understand this lockfile bollocks

* Upgrade to vite 2.0.4

* add fork of @svitejs/vite-plugin-svelte back to monorepo

* lint

* make run in node 12

* ffffuuuuuuu

* Fix file path

* specify vite 2.0.4 everywhere

* add some logging to try and diagnose CI test failures

* fix output directories

* remove logging

Co-authored-by: Ben McCann <322311+benmccann@users.noreply.github.com>
Rich-Harris pushed a commit that referenced this issue Mar 2, 2021
* Powered by Vite. Issues remain

* Fix esbuild version conflict in HN example by removing snowpack config

* Enable hot reload option

* Add layout css

* Get layout to show up in SSR

* More path fixes. CSR works now!

* Bump snowpack to reduce esbuild version conflicts

* get a few tests passing

* Fix

* [WIP] Vite prod builds (#1)

* WIP vite prod builds

* prettier

* HN example working, at least

* fix some stuff

* update config files

* various

* simplify

* simplify

* oops

* fix find_layout

* remove logging

* fix vite base path

* make vite a peer dependency

* let vite serve static assets

* get SSR CSS working

* remove unused code

* rename CLI

* simplify configs

* tweak relationship between different packages

* simplify app-utils

* update tests to remove app startup crashes in prod

* fix lockfile

* tweak some file locations etc, get some more tests passing

* get tests passing

* update lockfile

* update lockfile

* get all tests passing, locally at least

* remove snowpack-related stuff

* add vite-plugin-svelte to monorepo

* lint

* dont remove styles, it breaks stuff. TODO investigate

* Upgrade vite

* fix some sourcemap stuff

* remove vite-plugin-svelte from workspace until things settle down more

* fix lockfile

* gloss over import.meta transform bug for now

* hack around vite bugs until 2.0.4

* only lint src files

* remove source-map-support, it was causing weird stuff to happen

* ensure renderer waits for layout/error styles

* i really dont understand this lockfile bollocks

* Upgrade to vite 2.0.4

* add fork of @svitejs/vite-plugin-svelte back to monorepo

* lint

* make run in node 12

* ffffuuuuuuu

* Fix file path

* specify vite 2.0.4 everywhere

* add some logging to try and diagnose CI test failures

* fix output directories

* remove logging

Co-authored-by: Ben McCann <322311+benmccann@users.noreply.github.com>

* update lockfile

* remove merge conflict artifact

* fix unrelated typo

* restore alias

* remove some obsolete deps

Co-authored-by: Ben McCann <322311+benmccann@users.noreply.github.com>
Rich-Harris pushed a commit that referenced this issue Jan 11, 2022
Theo-Steiner referenced this issue in Theo-Steiner/kit Jan 24, 2022
This reverts commit cecf7dd.

Revert being stupid #1
Rich-Harris added a commit that referenced this issue Jan 26, 2022
…3521)

* Add failing test for #3473 prerender error body used already

* Fix reading from same response body twice during prerender

* Fix quotes

* Add changeset

* Fix casing for internal variables

* Revert change of cloning response as bug was actually in prerender.js

* Avoid reading response body twice

* Revert "Avoid reading response body twice"

This reverts commit cecf7dd.

Revert being stupid #1

* Revert "Revert change of cloning response as bug was actually in prerender.js"

This reverts commit 5e5f30b.

Revert being stupid #2

* store buffered depenedency bodies for prerendering

* failing test for non-buffered endpoint data

* use buffered body if available, otherwise buffer

Co-authored-by: Rich Harris <hello@rich-harris.dev>
benmccann added a commit that referenced this issue Dec 3, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant