Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't include baseUrl in generated tsconfig.json #11286

Closed
Rich-Harris opened this issue Dec 13, 2023 · 0 comments
Closed

Don't include baseUrl in generated tsconfig.json #11286

Rich-Harris opened this issue Dec 13, 2023 · 0 comments
Assignees
Milestone

Comments

@Rich-Harris
Copy link
Member

Describe the problem

Honestly I don't really have the context for all these, I'm just noting that we had planned to change them in v2 for whatever reason:

// TODO(v2): never include base URL, and skip the check below

// TODO(v2): find a better way to include all src files. We can't just use routes/lib only because
// people might have other folders/files in src that they want included.

moduleResolution: 'node', // TODO change to "bundler" in SvelteKit v2

// TODO(v2): use the new flag verbatimModuleSyntax instead (requires support by Vite/Esbuild)

// TODO(v2): check needs to be adjusted when we remove the base path

Describe the proposed solution

^

Alternatives considered

No response

Importance

nice to have

Additional Information

No response

@Rich-Harris Rich-Harris added this to the 2.0 milestone Dec 13, 2023
@dummdidumm dummdidumm self-assigned this Dec 13, 2023
dummdidumm added a commit that referenced this issue Dec 13, 2023
- don't generate baseUrl anymore and don't adjust paths anymore depending on whether or not the user has paths in their tsconfig.json
- more strict validation: warn on baseUrl/paths and suggest kit.alias instead

closes #11286
dummdidumm added a commit that referenced this issue Dec 13, 2023
- don't generate baseUrl anymore and don't adjust paths anymore depending on whether or not the user has paths in their tsconfig.json
- more strict validation: warn on baseUrl/paths and suggest kit.alias instead

closes #11286
Rich-Harris pushed a commit that referenced this issue Dec 13, 2023
- don't generate baseUrl anymore and don't adjust paths anymore depending on whether or not the user has paths in their tsconfig.json
- more strict validation: warn on baseUrl/paths and suggest kit.alias instead

closes #11286
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants