Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Type checking in adapters #625

Closed
benmccann opened this issue Mar 24, 2021 · 0 comments · Fixed by #4220
Closed

Type checking in adapters #625

benmccann opened this issue Mar 24, 2021 · 0 comments · Fixed by #4220
Labels
adapters - general Support for functionality general to all adapters types / typescript

Comments

@benmccann
Copy link
Member

Issue

The adapters don't have TypeScript. This leads two two big issues.

  1. we introduce bugs which would be caught with type checking https://github.com/sveltejs/kit/pull/600/files#r600142752
  2. VS Code is painful to use because everything is red squigglies

Screenshot from 2021-03-23 20-41-29

Possible solutions

microsoft/TypeScript#33079 (comment)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
adapters - general Support for functionality general to all adapters types / typescript
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

typecheck adapters sveltejs/kit
1 participant
@benmccann