-
-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[chore] ambient modules and imports #2266
Conversation
|
We can bikeshed |
Reminder for the next PR to also resolve #625 |
Updated the comments. For the polka issue we'll just have to ignore them for now, casting the types would make sense if we're actually writing TS, but ignoring them makes more sense here, plus we've also put our reasons for every ignore and expect errors so it's clearer than casting (which we should try to avoid if possible). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't know the reasons for adding @sveltejs/kit/node
etc, so I can't say much about that. Type-wise, this looks good. If I remember correctly, the type Page = import('@sveltejs/kit').Page
were needed because else they were not picked up during development on Kit itself. Did that change?
Thanks, and yes! Other than having to disable eslint duplicate imports, it seems to be working fine now. |
A stepping stone for #2223 and a groundwork for #2249