Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Vercel route splitting doesn't support handling 404s #8287

Closed
knd775 opened this issue Dec 29, 2022 · 0 comments · Fixed by #9265
Closed

Vercel route splitting doesn't support handling 404s #8287

knd775 opened this issue Dec 29, 2022 · 0 comments · Fixed by #9265
Labels
bug Something isn't working pkg:adapter-vercel Pertaining to the Vercel adapter ready to implement please submit PRs for these issues!
Milestone
soon

Comments

@knd775
Copy link

knd775 commented Dec 29, 2022

Describe the problem

When using split: true with the vercel adapter, 404s are handled by vercel instead of +error.svelte or error.html.

Describe the proposed solution

Add a catchall route that uses +error.svelte to handle the 404 error like an app with split: false would

Alternatives considered

No response

Importance

would make my life easier

Additional Information

No response
@benmccann benmccann added the pkg:adapter-vercel Pertaining to the Vercel adapter label Dec 30, 2022
@Rich-Harris Rich-Harris added the bug Something isn't working label Jan 28, 2023
@Rich-Harris Rich-Harris added this to the soon milestone Jan 28, 2023
@Rich-Harris Rich-Harris added the ready to implement please submit PRs for these issues! label Jan 28, 2023
Rich-Harris added a commit that referenced this issue Mar 1, 2023
@Rich-Harris
add catch-all route for framework 404s rather than platform 404s - cl…
34404fb 
…oses #8287
@Rich-Harris Rich-Harris mentioned this issue Mar 1, 2023
Merged
5 tasks
Rich-Harris added a commit that referenced this issue Mar 1, 2023
@Rich-Harris @dummdidumm
add catch-all route for framework 404s rather than platform 404s (#9265)
6bd50f8 
* add catch-all route for framework 404s rather than platform 404s - closes #8287

* Update packages/adapter-vercel/index.js

Co-authored-by: Simon H <5968653+dummdidumm@users.noreply.github.com>

---------

Co-authored-by: Simon H <5968653+dummdidumm@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working pkg:adapter-vercel Pertaining to the Vercel adapter ready to implement please submit PRs for these issues!
Projects
None yet
Milestone
soon
Development

Successfully merging a pull request may close this issue.

add catch-all route for framework 404s rather than platform 404s sveltejs/kit
3 participants
@benmccann @Rich-Harris @knd775