Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Vercel adapter error in vercel app #8911

Closed
arinzejustin opened this issue Feb 6, 2023 · 4 comments
Closed

Vercel adapter error in vercel app #8911

arinzejustin opened this issue Feb 6, 2023 · 4 comments

Comments

@arinzejustin
Copy link

Describe the bug

Start to get this error in vercel build immediately after this recent update that is not more than 1 hour now @sveltejs/adapter-vercel

Reproduction

https://github.com/arinzejustin/cryptflix/dashboard

Logs

TypeError: builder.routes is not iterable
--
18:35:57.663 | at Object.adapt (file:///vercel/path0/dashboard/node_modules/@sveltejs/adapter-vercel/index.js:155:32)
18:35:57.664 | at Object.adapt (file:///vercel/path0/dashboard/node_modules/@sveltejs/adapter-auto/index.js:103:19)
18:35:57.664 | at adapt (file:///vercel/path0/dashboard/node_modules/@sveltejs/adapter-auto/index.js:114:31)
18:35:57.664 | at async adapt (file:///vercel/path0/dashboard/node_modules/@sveltejs/kit/src/core/adapt/index.js:28:2)
18:35:57.664 | at async Object.handler (file:///vercel/path0/dashboard/node_modules/@sveltejs/kit/src/exports/vite/index.js:694:6)
18:35:57.664 | at async PluginDriver.hookParallel (file:///vercel/path0/dashboard/node_modules/rollup/dist/es/shared/rollup.js:23626:17)
18:35:57.664 | at async Object.close (file:///vercel/path0/dashboard/node_modules/rollup/dist/es/shared/rollup.js:24931:13)
18:35:57.664 | at async Promise.all (index 0)
18:35:57.664 | at async build (file:///vercel/path0/dashboard/node_modules/vite/dist/node/chunks/dep-5e7f419b.js:44352:13)
18:35:57.664 | at async CAC.<anonymous> (file:///vercel/path0/dashboard/node_modules/vite/dist/node/cli.js:808:9)
18:35:57.693 | Error: Command "npm run build" exited with 1

System Info

Vercel app

Severity

blocking an upgrade

Additional Information

No response

@dit7ya
Copy link

dit7ya commented Feb 6, 2023

I can confirm I am also getting the same error on Vercel and locally via yarn build as well. I guessing this is due to the fact that adapter-auto does not enforce the same semver on the adapter-vercel package. (So my adapter-auto is at 1.0.0, while it tries to use adapter-vercel of 2.0.0).

I will try to post a minimal repro tomorrow.

@Smirow
Copy link

Smirow commented Feb 6, 2023

see #8907 ?

"@sveltejs/adapter-auto": "^2.0.0", should do the trick

@dit7ya
Copy link

dit7ya commented Feb 6, 2023

Thanks @Smirow. However, just that did not work for me.

For anybody coming to this thread, you need to update to the following.

    "@sveltejs/adapter-auto": "^2.0.0",
    "@sveltejs/kit": "^1.5.0",

dummdidumm added a commit that referenced this issue Feb 6, 2023
For the Vercel and Netlify adapters. adapter-auto on earlier versions could install them when it shouldn't
Related to #8911
Rich-Harris pushed a commit that referenced this issue Feb 6, 2023
For the Vercel and Netlify adapters. adapter-auto on earlier versions could install them when it shouldn't
Related to #8911
@Rich-Harris
Copy link
Member

closed via #8915

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants