-
-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: better error message for preview if build output doesn't exist #10337
Conversation
🦋 Changeset detectedLatest commit: e19ceb8 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
@@ -36,6 +36,10 @@ export async function preview(vite, vite_config, svelte_config) { | |||
|
|||
const dir = join(svelte_config.kit.outDir, 'output/server'); | |||
|
|||
if (!existsSync(dir)) { | |||
throw new Error(`Server files not found at ${dir}, did you run \`build\` first?`); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
throw new Error(`Server files not found at ${dir}, did you run \`build\` first?`); | |
throw new Error(`Server files not found at ${dir}, did you run \`vite build\` first?`); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I had that in my first iteration but removed the vite part because people usually run the build script in their package.json instead of invoking the vite CLI by itself.
Co-authored-by: Conduitry <git@chor.date>
closes #10334
Please don't delete this checklist! Before submitting the PR, please make sure you do the following:
Tests
pnpm test
and lint the project withpnpm lint
andpnpm check
Changesets
pnpm changeset
and following the prompts. Changesets that add features should beminor
and those that fix bugs should bepatch
. Please prefix changeset messages withfeat:
,fix:
, orchore:
.