Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: better error message for preview if build output doesn't exist #10337

Merged
merged 3 commits into from
Jul 7, 2023

Conversation

gtm-nayan
Copy link
Contributor

closes #10334

Please don't delete this checklist! Before submitting the PR, please make sure you do the following:

  • It's really useful if your PR references an issue where it is discussed ahead of time. In many cases, features are absent for a reason. For large changes, please create an RFC: https://github.com/sveltejs/rfcs
  • This message body should clearly illustrate what problems it solves.
  • Ideally, include a test that fails without this PR but passes with it.

Tests

  • Run the tests with pnpm test and lint the project with pnpm lint and pnpm check

Changesets

  • If your PR makes a change that should be noted in one or more packages' changelogs, generate a changeset by running pnpm changeset and following the prompts. Changesets that add features should be minor and those that fix bugs should be patch. Please prefix changeset messages with feat:, fix:, or chore:.

@changeset-bot
Copy link

changeset-bot bot commented Jul 7, 2023

🦋 Changeset detected

Latest commit: e19ceb8

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@sveltejs/kit Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@@ -36,6 +36,10 @@ export async function preview(vite, vite_config, svelte_config) {

const dir = join(svelte_config.kit.outDir, 'output/server');

if (!existsSync(dir)) {
throw new Error(`Server files not found at ${dir}, did you run \`build\` first?`);
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
throw new Error(`Server files not found at ${dir}, did you run \`build\` first?`);
throw new Error(`Server files not found at ${dir}, did you run \`vite build\` first?`);

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I had that in my first iteration but removed the vite part because people usually run the build script in their package.json instead of invoking the vite CLI by itself.

Co-authored-by: Conduitry <git@chor.date>
@dummdidumm dummdidumm merged commit 486a971 into master Jul 7, 2023
@dummdidumm dummdidumm deleted the preview-error-improve branch July 7, 2023 07:06
@github-actions github-actions bot mentioned this pull request Jul 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Preview not working (npm run preview)
4 participants