Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: wait for title before updating announcer #10363

Merged
merged 2 commits into from
Jul 11, 2023
Merged

fix: wait for title before updating announcer #10363

merged 2 commits into from
Jul 11, 2023

Conversation

geoffrich
Copy link
Member

@geoffrich geoffrich commented Jul 11, 2023

Fixes #10360

When you set the page title using $page.data in a layout (see linked issue for the concrete use case), the document's title is not updated until after the page store has fired its subscription callbacks. This means that the announcer uses the previous page's title instead and announces the wrong route.

This PR fixes this by waiting a tick before reading the new title.

No test, because the existing ones set the title directly in each page component, and refactoring those to return the page title instead seemed like too much for an edge case.

Please don't delete this checklist! Before submitting the PR, please make sure you do the following:

  • It's really useful if your PR references an issue where it is discussed ahead of time. In many cases, features are absent for a reason. For large changes, please create an RFC: https://github.com/sveltejs/rfcs
  • This message body should clearly illustrate what problems it solves.
  • Ideally, include a test that fails without this PR but passes with it.

Tests

  • Run the tests with pnpm test and lint the project with pnpm lint and pnpm check

Changesets

  • If your PR makes a change that should be noted in one or more packages' changelogs, generate a changeset by running pnpm changeset and following the prompts. Changesets that add features should be minor and those that fix bugs should be patch. Please prefix changeset messages with feat:, fix:, or chore:.

@changeset-bot
Copy link

changeset-bot bot commented Jul 11, 2023

🦋 Changeset detected

Latest commit: 784efb6

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@sveltejs/kit Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@dummdidumm dummdidumm merged commit 23d1df7 into master Jul 11, 2023
12 checks passed
@dummdidumm dummdidumm deleted the grich/10360 branch July 11, 2023 06:25
@github-actions github-actions bot mentioned this pull request Jul 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

svelte-announcer ends up "behind" a page if the title-tag is added in +layout.svelte instead of +page.svelte
2 participants