Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(create-svelte): bump typescript-eslint to v6 #10371

Merged
merged 3 commits into from
Sep 9, 2023
Merged

chore(create-svelte): bump typescript-eslint to v6 #10371

merged 3 commits into from
Sep 9, 2023

Conversation

hyunbinseo
Copy link
Contributor

Upgraded SvelteKit templates to typescript-eslint v6.


.eslintrc.cjs has been added to the .eslintignore file.

Parsing error: ESLint was configured to run on <tsconfigRootDir>/.eslintrc.cjs using parserOptions.project: ~

However, that TSConfig does not include this file. Either:

  • Change ESLint's list of included files to not include this file ⬅️
  • Change that TSConfig to include this file
  • Create a new TSConfig that includes this file and include it in your parserOptions.project

See the typescript-eslint docs for more info: https://typescript-eslint.io/linting/troubleshooting#i-get-errors-telling-me-eslint-was-configured-to-run--however-that-tsconfig-does-not--none-of-those-tsconfigs-include-this-fileeslint


Please don't delete this checklist! Before submitting the PR, please make sure you do the following:

  • It's really useful if your PR references an issue where it is discussed ahead of time. In many cases, features are absent for a reason. For large changes, please create an RFC: https://github.com/sveltejs/rfcs
  • This message body should clearly illustrate what problems it solves.
  • Ideally, include a test that fails without this PR but passes with it.

Tests

  • Run the tests with pnpm test and lint the project with pnpm lint and pnpm check

Changesets

  • If your PR makes a change that should be noted in one or more packages' changelogs, generate a changeset by running pnpm changeset and following the prompts. Changesets that add features should be minor and those that fix bugs should be patch. Please prefix changeset messages with feat:, fix:, or chore:.

@changeset-bot
Copy link

changeset-bot bot commented Jul 12, 2023

🦋 Changeset detected

Latest commit: 9a42f2b

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
create-svelte Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@hyunbinseo hyunbinseo changed the title chore: bump typescript-eslint to v6 chore(create-svelte): bump typescript-eslint to v6 Jul 12, 2023
@ghostdevv
Copy link
Member

Does svelte-eslint-parser support v6?

@polyzen
Copy link

polyzen commented Jul 16, 2023

sveltejs/eslint-plugin-svelte#533

@polyzen
Copy link

polyzen commented Jul 16, 2023

This PR also adds typed linting, which last time I checked did not play well with Svelte's inferred typing.

@hyunbinseo hyunbinseo marked this pull request as draft July 16, 2023 23:09
@benmccann
Copy link
Member

Does svelte-eslint-parser support v6?
sveltejs/eslint-plugin-svelte#533

That issue has been closed

This PR also adds typed linting, which last time I checked did not play well with Svelte's inferred typing.

Thanks for pointing that out. Let's revert that portion then, which seems like a separate change from the upgrade

@benmccann benmccann marked this pull request as ready for review September 9, 2023 12:17
@benmccann benmccann merged commit 3735c32 into sveltejs:master Sep 9, 2023
@github-actions github-actions bot mentioned this pull request Sep 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants