Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(deps): update dependency prettier-plugin-svelte to v3 #10408

Closed
wants to merge 1 commit into from

Conversation

renovate[bot]
Copy link
Contributor

@renovate renovate bot commented Jul 19, 2023

Mend Renovate

This PR contains the following updates:

Package Change Age Adoption Passing Confidence
prettier-plugin-svelte ^2.10.1 -> ^3.0.0 age adoption passing confidence

Release Notes

sveltejs/prettier-plugin-svelte (prettier-plugin-svelte)

v3.0.0

Compare Source

  • (breaking) requires prettier version 3. This may require adjustments to your configuration file, see the migration guide for more info
  • (breaking) requires node version 14 or higher
  • (breaking) Whether or not empty elements/components should self-close is now left to the user - in other words, if you write <div /> or <Component /> that stays as is, and so does <div></div>/<Component></Component>. If svelteStrictMode is turned on, it will still only allow <div></div> notation for elements (but it will leave your components alone)
  • (breaking) svelteAllowShorthand now takes precedence over svelteStrictMode, which no longer has any effect on that behavior. Set svelteAllowShorthand to false to get back the v2 behavior
  • (breaking) remove deprecated svelteSortOrder options

Configuration

📅 Schedule: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined).

🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.

Rebasing: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.

🔕 Ignore: Close this PR and you won't be reminded about this update again.


  • If you want to rebase/retry this PR, check this box

This PR has been generated by Mend Renovate. View repository job log here.

@changeset-bot
Copy link

changeset-bot bot commented Jul 19, 2023

⚠️ No Changeset found

Latest commit: 52f5911

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@danawoodman
Copy link
Contributor

This seems to be broken: just setup a new project and I'm getting an error saying unknown option "pluginSearchDirs" and then running npm run format does not format Svelte files.

@dummdidumm
Copy link
Member

Make sure to read the migration guide: https://github.com/sveltejs/prettier-plugin-svelte#how-to-migrate-from-version-2-to-3
Just bumping the plugin won't suffice, we need to do #10410 instead.

@danawoodman
Copy link
Contributor

This was a brand new project created today tho 😅

@dummdidumm
Copy link
Member

I'm confused, so the problem happens with prettier version 2?

@danawoodman
Copy link
Contributor

Now I'm not sure what I did, perhaps I blacked out and installed v3... I just setup a new Kit app and its pinned to v2 so I must have done something weird, ignore me @dummdidumm !

@benmccann
Copy link
Member

tracking this in #10410

@benmccann benmccann closed this Aug 10, 2023
@benmccann benmccann deleted the renovate/prettier-plugin-svelte-3.x branch August 10, 2023 20:21
@renovate
Copy link
Contributor Author

renovate bot commented Aug 10, 2023

Renovate Ignore Notification

Because you closed this PR without merging, Renovate will ignore this update. You will not get PRs for any future 3.x releases. But if you manually upgrade to 3.x then Renovate will re-enable minor and patch updates automatically.

If you accidentally closed this PR, or if you changed your mind: rename this PR to get a fresh replacement PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants