fix: do not copy vite manifest instead of removing during build

[eltigerchino]

fixes #10268

I can't reproduce the original issue on my system but this simple fix makes it worth leaving the Vite manifest file alone?
We can just remove it when copying files so it doesn't get exposed publicly. #8360 #8815

This would also make it forwards compatible with whatever vite files get generated in the future since Vite 5 will put all these files in the .vite folder. vitejs/vite#9636 (comment) https://github.com/vitejs/vite/pull/14230/files

Please don't delete this checklist! Before submitting the PR, please make sure you do the following:

• It's really useful if your PR references an issue where it is discussed ahead of time. In many cases, features are absent for a reason. For large changes, please create an RFC: https://github.com/sveltejs/rfcs
• This message body should clearly illustrate what problems it solves.
• Ideally, include a test that fails without this PR but passes with it.

Tests

• Run the tests with pnpm test and lint the project with pnpm lint and pnpm check

Changesets

• If your PR makes a change that should be noted in one or more packages' changelogs, generate a changeset by running pnpm changeset and following the prompts. Changesets that add features should be minor and those that fix bugs should be patch. Please prefix changeset messages with feat:, fix:, or chore:.

[changeset-bot]

🦋 Changeset detected

Latest commit: 64d187d

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package

Name	Type
@sveltejs/kit	Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

[benmccann]

I'm not really sure this is a good idea. It kind of seems like it'd just be papering over whatever the root cause is. I don't know what's going to happen if you run two builds in parallel even if you leave that file in place. And I don't expect this would actually fix the issue anyway because you're not moving it to happen very much later. Finally, I'm worried that some adapter might copy files in their own custom way and then be left with the manifest in their build

[eltigerchino]

Yeah, I have to agree. I had these two concerns as well.

• papering over whatever the root cause is
• some adapter might copy files in their own custom way and then be left with the manifest in their build

However,

And I don't expect this would actually fix the issue anyway because you're not moving it to happen very much later.

It should address the issue if we leave the manifest in .svelte-kit/output/... because it only errors when trying to read it there. We only remove it in the actual build output.

I'm worried that some adapter might copy files in their own custom way and then be left with the manifest in their build

If they did have a custom copying process, maybe they should also have the responsibility of not copying the Vite files over. Alternatively, we could move the Vite build artefacts outside the client and server bundle directories into its own thing? (and rename them .vite/client-manifest.json and .vite/server-manifest.json

[benmccann]

Ah, right. Thanks for clarifying. I think that's probably an okay idea then. There have been times where I would have found it very helpful to have the Vite manifest for debugging, so leaving it in the .svelte-kit output and then just having the adapter skip copying it could be helpful