Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: vite 5 test compatibility #10896

Merged
merged 1 commit into from
Oct 20, 2023
Merged

chore: vite 5 test compatibility #10896

merged 1 commit into from
Oct 20, 2023

Conversation

bluwy
Copy link
Member

@bluwy bluwy commented Oct 20, 2023

Fix some Vite 5 compat issues:

  1. SVGs are now inline-able: A test was fetching an SVG path but it's data: now, so it's unfetch-able. I refactored to use large.png from the /asset-import route instead.
  2. Rollup file name hash are now url-safe base64, so I updated the test to match that regex

https://rollupjs.org/migration/:

Otherwise, an obvious change is that Rollup now uses url-safe base64 hashes in file names instead of the older base16 hashes. This provides more hash safety but means that hash length is now limited to at most 22 characters for technical reasons.

Please don't delete this checklist! Before submitting the PR, please make sure you do the following:

  • It's really useful if your PR references an issue where it is discussed ahead of time. In many cases, features are absent for a reason. For large changes, please create an RFC: https://github.com/sveltejs/rfcs
  • This message body should clearly illustrate what problems it solves.
  • Ideally, include a test that fails without this PR but passes with it.

Tests

  • Run the tests with pnpm test and lint the project with pnpm lint and pnpm check

Changesets

  • If your PR makes a change that should be noted in one or more packages' changelogs, generate a changeset by running pnpm changeset and following the prompts. Changesets that add features should be minor and those that fix bugs should be patch. Please prefix changeset messages with feat:, fix:, or chore:.

@changeset-bot
Copy link

changeset-bot bot commented Oct 20, 2023

⚠️ No Changeset found

Latest commit: 2c7aa90

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@benmccann benmccann changed the title test: fix vite 5 compat chore: vite 5 test compatibility Oct 20, 2023
@benmccann benmccann merged commit b196712 into master Oct 20, 2023
14 checks passed
@benmccann benmccann deleted the fix-vite-5-compat branch October 20, 2023 16:45
@benmccann benmccann mentioned this pull request Oct 20, 2023
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants