Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: only resolve images if optimizable #11041

Merged
merged 1 commit into from
Nov 15, 2023
Merged

fix: only resolve images if optimizable #11041

merged 1 commit into from
Nov 15, 2023

Conversation

benmccann
Copy link
Member

No description provided.

Copy link

changeset-bot bot commented Nov 14, 2023

🦋 Changeset detected

Latest commit: 1f83839

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@sveltejs/enhanced-img Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@benjaminpreiss
Copy link

@benmccann Does this allow for passing regular urls into the enhanced:img component?

E.g. forwarding a regular URL received through a prop in a component:

<script>
    export let url: string
</script>

<enhanced:img {src} alt="" />

where url is not imported via the ?enhanced query.

@benmccann
Copy link
Member Author

No. You'd still need the ?enhanced query parameter in that case.

@eltigerchino eltigerchino merged commit e785ac5 into master Nov 15, 2023
14 checks passed
@eltigerchino eltigerchino deleted the non-opt branch November 15, 2023 15:55
@github-actions github-actions bot mentioned this pull request Nov 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants