Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs: add performance page #11424

Merged
merged 19 commits into from
Dec 26, 2023
Merged

docs: add performance page #11424

merged 19 commits into from
Dec 26, 2023

Conversation

benmccann
Copy link
Member

No description provided.

@benmccann benmccann added the documentation Improvements or additions to documentation label Dec 21, 2023
@changeset-bot changeset-bot
Copy link

changeset-bot bot commented Dec 21, 2023 •
edited
Loading

⚠️ No Changeset found

Latest commit: e6a0d97

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

theetrain
theetrain reviewed Dec 21, 2023
View reviewed changes
Copy link
Contributor

@theetrain theetrain left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall this is great! Once published there may be an opportunity to recommend "perceived performance" strategies via streaming with promises.

documentation/docs/40-best-practices/05-performance.md Outdated Show resolved Hide resolved
documentation/docs/40-best-practices/05-performance.md Outdated Show resolved Hide resolved
@benmccann
Copy link
Member Author

there may be an opportunity to recommend "perceived performance" strategies via streaming with promises

Thanks for the idea! I added a bit about streaming with promises as well as a couple other new sections.

Rich-Harris
Rich-Harris reviewed Dec 26, 2023
View reviewed changes
documentation/docs/40-best-practices/05-performance.md Outdated Show resolved Hide resolved
documentation/docs/40-best-practices/05-performance.md Outdated Show resolved Hide resolved
documentation/docs/40-best-practices/05-performance.md Outdated Show resolved Hide resolved
documentation/docs/40-best-practices/05-performance.md Outdated Show resolved Hide resolved
documentation/docs/40-best-practices/05-performance.md Outdated Show resolved Hide resolved
documentation/docs/40-best-practices/05-performance.md Outdated Show resolved Hide resolved
documentation/docs/40-best-practices/05-performance.md Outdated Show resolved Hide resolved
documentation/docs/40-best-practices/05-performance.md Outdated Show resolved Hide resolved
documentation/docs/40-best-practices/05-performance.md Outdated Show resolved Hide resolved
documentation/docs/40-best-practices/05-performance.md Outdated Show resolved Hide resolved
@Rich-Harris @benmccann
Update documentation/docs/40-best-practices/05-performance.md
8c44e17 
Co-authored-by: Ben McCann <322311+benmccann@users.noreply.github.com>
@Rich-Harris @benmccann
Update documentation/docs/40-best-practices/05-performance.md
8c5f2fb 
Co-authored-by: Ben McCann <322311+benmccann@users.noreply.github.com>
@Rich-Harris Rich-Harris merged commit 6419d3e into main Dec 26, 2023
12 of 13 checks passed
@Rich-Harris Rich-Harris deleted the perf-docs branch December 26, 2023 21:51
eltigerchino pushed a commit that referenced this pull request Jan 9, 2024
@benmccann @Rich-Harris @eltigerchino
docs: add performance page (#11424)
3ac5e78 
* docs: add performance page

* address minor feedback issues

* lazy loading and waterfalls

* prefetching

* Apply suggestions from code review

* Apply suggestions from code review

* various

* tweak

* MDN page says nothing about lazy-loading videos

* fix link

* Update documentation/docs/40-best-practices/05-performance.md

Co-authored-by: Ben McCann <322311+benmccann@users.noreply.github.com>

* move images page

* Update documentation/docs/40-best-practices/05-performance.md

Co-authored-by: Ben McCann <322311+benmccann@users.noreply.github.com>

* update font section (no point mentioning font-display without a recommended value)

* various tweaks

---------

Co-authored-by: Rich Harris <richard.a.harris@gmail.com>
Co-authored-by: Rich Harris <rich.harris@vercel.com>
eltigerchino added a commit that referenced this pull request Jan 15, 2024
@eltigerchino @benmccann
@github-actions @renovate @Rich-Harris @geoffrich
feat: include server assets for Vercel serverless functions (#10979)
fe1a11e 
* add ability to copy server assets per route

* changeset

* fix test

* fix doc

* fix asset copying

* change process dir when using vite preview

* remove process.chdir from vite preview

* include assets used by default error pages

* fix doc link

* better doc example

* fix doc type

* ok for real

* add tests for vercel adapter

* prettier

* fix tests

* fix types

* more type fixes

* try this

* documentation

* skip adapter-vercel tests if on node v20

* oopsie wrong PR

* move server asset metadata resolving to function

* update changesets

* revert builder test fixes

* fix lockfile

* prettier

* lint

* fix vercel tsc errors

* prepublish only

* fix: avoid running load functions when prerendering if no server load function exists and SSR is off (#11405)

* chore: upgrade eslint-plugin-unicorn (#11432)

* Version Packages (#11420)

Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>

* chore(deps): update dependency worktop to v0.8.0-next.16 (#11437)

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>

* i don't think we need this any more (#11439)

Co-authored-by: Rich Harris <rich.harris@vercel.com>

* fix: only disallow dynamic env access when prerendering (#11436)

* only disallow dynamic env access when prerendering

* changeset

* add test

* sigh

---------

Co-authored-by: Rich Harris <rich.harris@vercel.com>

* docs: fix links to sveltesociety.dev (#11441)

* Version Packages (#11442)

Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>

* fix: set ESLint config type to `Config` instead of `FlatConfig` (#11453)

* Version Packages (#11457)

Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>

* fix: improve warning when encountering import.meta.env (#11440)

* empty commit (#11469)

Co-authored-by: Rich Harris <rich.harris@vercel.com>

* fix form actions docs (#11470)

Co-authored-by: Rich Harris <rich.harris@vercel.com>

* Version Packages (#11468)

Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>

* chore(deps): update pnpm to v8.13.1 (#11471)

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>

* docs: add performance page (#11424)

* docs: add performance page

* address minor feedback issues

* lazy loading and waterfalls

* prefetching

* Apply suggestions from code review

* Apply suggestions from code review

* various

* tweak

* MDN page says nothing about lazy-loading videos

* fix link

* Update documentation/docs/40-best-practices/05-performance.md

Co-authored-by: Ben McCann <322311+benmccann@users.noreply.github.com>

* move images page

* Update documentation/docs/40-best-practices/05-performance.md

Co-authored-by: Ben McCann <322311+benmccann@users.noreply.github.com>

* update font section (no point mentioning font-display without a recommended value)

* various tweaks

---------

Co-authored-by: Rich Harris <richard.a.harris@gmail.com>
Co-authored-by: Rich Harris <rich.harris@vercel.com>

* chore(deps): update pnpm to v8.14.0 (#11504)

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>

* feat: use latest Azure adapter in adapter-auto (#11496)

* fix: update @vercel/nft to 0.26.1 (#11508)

* Version Packages (#11507)

Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>

* exclude universal nodes

* include assets imported by server hooks

* update adapter-vercel tests

* fix tests

* fix and add test for server hooks assets

* update adapter-vercel test app packages

* im gonna lose my mind

* ignore hashes for filenames in tests

* oops

* fix tests?

* revert adapter-vercel types fix

* improve readability of route asset for loop

* simplify file reading in serverless functions example

---------

Co-authored-by: Ben McCann <322311+benmccann@users.noreply.github.com>
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Co-authored-by: Rich Harris <richard.a.harris@gmail.com>
Co-authored-by: Rich Harris <rich.harris@vercel.com>
Co-authored-by: Geoff Rich <4992896+geoffrich@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@elliott-with-the-longest-name-on-github elliott-with-the-longest-name-on-github elliott-with-the-longest-name-on-github left review comments

@braebo braebo braebo left review comments

@theetrain theetrain theetrain left review comments

@Rich-Harris Rich-Harris Rich-Harris approved these changes

Assignees
No one assigned
Labels
documentation Improvements or additions to documentation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@benmccann @Rich-Harris @theetrain @braebo @elliott-with-the-longest-name-on-github