Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: version range handling in update_pkg function #11716

Merged
merged 20 commits into from
Jan 25, 2024

Conversation

codenoid
Copy link
Contributor

@codenoid codenoid commented Jan 23, 2024

keep user's library version if higher than hard-defined version

fixes #11693


Tests

  • Run the tests with pnpm test and lint the project with pnpm lint and pnpm check

Changesets

  • If your PR makes a change that should be noted in one or more packages' changelogs, generate a changeset by running pnpm changeset and following the prompts. Changesets that add features should be minor and those that fix bugs should be patch. Please prefix changeset messages with feat:, fix:, or chore:.

keep user's library version if higher than hard-defined version
Copy link

changeset-bot bot commented Jan 23, 2024

🦋 Changeset detected

Latest commit: 7bce6df

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
svelte-migrate Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@codenoid
Copy link
Contributor Author

let me add another test

@codenoid codenoid requested a review from dummdidumm January 23, 2024 19:36
Copy link
Member

@dummdidumm dummdidumm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you! This looks much better, left a few comments

.changeset/silly-donkeys-shout.md Outdated Show resolved Hide resolved
packages/migrate/migrations/sveltekit-2/migrate.spec.js Outdated Show resolved Hide resolved
packages/migrate/utils.js Outdated Show resolved Hide resolved
@codenoid codenoid requested a review from dummdidumm January 25, 2024 10:28
pnpm-lock.yaml Outdated Show resolved Hide resolved
@codenoid codenoid requested a review from dummdidumm January 25, 2024 11:03
@eltigerchino eltigerchino added the pkg:svelte-migrate Issues related to the svelte-migrate package label Jan 25, 2024
Copy link
Member

@dummdidumm dummdidumm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@dummdidumm dummdidumm merged commit 0dfb0cc into sveltejs:main Jan 25, 2024
10 of 12 checks passed
@github-actions github-actions bot mentioned this pull request Jan 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pkg:svelte-migrate Issues related to the svelte-migrate package
Projects
None yet
Development

Successfully merging this pull request may close these issues.

svelte-migrate downgrades adapters
3 participants