Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: support shorthand attribute syntax on enhanced-img #11884

Merged

Conversation

LorisSigrist
Copy link
Contributor

This PR adds support for the Attribute shorthand syntax on <enhanced:img components.
It is now possible to write the following code:

<script>
  import src from "$lib/myImage.png?enhanced"
</script>

<enhanced:img {src} />

Previously this would error

Please don't delete this checklist! Before submitting the PR, please make sure you do the following:

  • It's really useful if your PR references an issue where it is discussed ahead of time. In many cases, features are absent for a reason. For large changes, please create an RFC: https://github.com/sveltejs/rfcs
  • This message body should clearly illustrate what problems it solves.
  • Ideally, include a test that fails without this PR but passes with it.

Tests

  • Run the tests with pnpm test and lint the project with pnpm lint and pnpm check

Changesets

  • If your PR makes a change that should be noted in one or more packages' changelogs, generate a changeset by running pnpm changeset and following the prompts. Changesets that add features should be minor and those that fix bugs should be patch. Please prefix changeset messages with feat:, fix:, or chore:.

Edits

  • Please ensure that 'Allow edits from maintainers' is checked. PRs without this option may be closed.

Copy link

changeset-bot bot commented Feb 22, 2024

🦋 Changeset detected

Latest commit: e648afe

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@sveltejs/enhanced-img Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@eltigerchino eltigerchino changed the title Enhanced Image: Support {AttributeShorthand} syntax fix: support attribute shorthand syntax for <enhanced:img> Feb 23, 2024
spudunk

This comment was marked as spam.

@ghostdevv ghostdevv changed the title fix: support attribute shorthand syntax for <enhanced:img> fix: support shorthand attribute syntax on enhanced-img Mar 3, 2024
@ghostdevv ghostdevv requested a review from benmccann March 3, 2024 07:11
@@ -42,3 +42,7 @@
<source srcset="./foo.avif 500v ./bar.avif 100v" />
<source srcset="./foo.avif, ./bar.avif 1v" />
</picture>

{#each images as src}
<enhanced:img {src} alt="opt-in test" />
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I just pushed a small change to change this from "opt-in test" to "attribute shorthand test"

@benmccann
Copy link
Member

Thank you so much for this! Sorry it took me awhile to get to reviewing it. I'll merge it in just a minute when the CI turns green

@benmccann benmccann merged commit bd2eae7 into sveltejs:main Mar 14, 2024
12 checks passed
@github-actions github-actions bot mentioned this pull request Mar 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants