-
-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add platformProxy
option to configure getPlatformProxy
#12011
Conversation
🦋 Changeset detectedLatest commit: deab0fd The changes in this PR will be included in the next version bump. This PR includes changesets to release 2 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
getPlatformProxy
via a new platformProxy
optionplatformProxy
option to configure getPlatformProxy
documentation/docs/25-build-and-deploy/70-adapter-cloudflare-workers.md
Outdated
Show resolved
Hide resolved
Also very interested in this 👍 Is there anything that can be done to move this forward? My use case is the following (I believe it is not that uncommon): |
+1 to this. Same exact use case over here. I'm currently using a patched version of the adapter-cloudflare package to workaround this. |
documentation/docs/25-build-and-deploy/70-adapter-cloudflare-workers.md
Outdated
Show resolved
Hide resolved
documentation/docs/25-build-and-deploy/60-adapter-cloudflare.md
Outdated
Show resolved
Hide resolved
documentation/docs/25-build-and-deploy/70-adapter-cloudflare-workers.md
Outdated
Show resolved
Hide resolved
documentation/docs/25-build-and-deploy/70-adapter-cloudflare-workers.md
Outdated
Show resolved
Hide resolved
documentation/docs/25-build-and-deploy/60-adapter-cloudflare.md
Outdated
Show resolved
Hide resolved
documentation/docs/25-build-and-deploy/70-adapter-cloudflare-workers.md
Outdated
Show resolved
Hide resolved
Thank you! (and sorry this took so long) |
Thank you team 🎉 |
Note
I've run
check
&lint
but not alltest
scripts because I don't see any specific tests in the two packages'package.json
, and some of tests fail on my machine (chromium-dev
related) but I don't think they are related to the change here.Context
Today,
adapter-cloudflare
andadapter-cloudflare-worker
use Wrangler API's getPlatformProxy forplatform
emulation duringdev
&preview
, but not yet allow passing configuration parameter togetPlatformProxy
. This PR adds aplatformProxy
adapter option to do just that.Use case
My specific use case is to set
persist.path
to a custom directory (equivalent to the --persist-to flag when using wrangler CLI). This allows me to set up two SvelteKit projects in a monorepo to use the same local sqlite database during dev & preview.Please don't delete this checklist! Before submitting the PR, please make sure you do the following:
Tests
pnpm test
and lint the project withpnpm lint
andpnpm check
Changesets
pnpm changeset
and following the prompts. Changesets that add features should beminor
and those that fix bugs should bepatch
. Please prefix changeset messages withfeat:
,fix:
, orchore:
.Edits