-
-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: upgrade eslint in create-svelte to v9 #12089
Conversation
🦋 Changeset detectedLatest commit: bb12553 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
} | ||
}, | ||
{ | ||
ignores: ['build/', '.svelte-kit/', 'package/', 'vite.config.[jt]s.timestamp-*'] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not sure what build
and package
directories are used for, but they were in the .eslintignore
.
ESLint doesn't seem to care about .DS_Store
, .env*
, pnpm-lock.yaml
, package-lock.json
or yarn.lock
, so I didn't add them.
I've also skipped node_modules
, since it's ignored by default.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I believe build
is the output directory for adapter-static, etc. and package
is the directory when packaging the lib directory with @sveltejs/package? (not sure myself)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I believe
build
is the output directory for adapter-static, etc.
I think that's correct, found this in docs: https://kit.svelte.dev/docs/adapter-static#options-pages.
package
is the directory when packaging the lib directory with @sveltejs/package? (not sure myself)
I've created a new library using yarn create svelte
and ran yarn run package
. It created a dist
directory, so package
must be for something else.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I believe that's the case, yeah. And regarding some of the other files, it seems they are leftovers from the time they decided to stop using .gitignore
as the ignore file for eslint
and prettier
.
I believe
build
is the output directory for adapter-static, etc. andpackage
is the directory when packaging the lib directory with @sveltejs/package? (not sure myself)
@ota-meshi do we have to update the combined eslint + prettier template to add the ruleset that disables some rules to avoid prettier conflicts? |
@dominikg I think that's what https://github.com/prettier/eslint-config-prettier is supposed to do. |
i mean https://github.com/sveltejs/eslint-plugin-svelte?tab=readme-ov-file#new-config-eslintconfigjs specifically |
@dominikg You're right, should be fixed now. Strange that it wasn't there before, since it was introduced way back in https://github.com/sveltejs/eslint-plugin-svelte/releases/tag/v2.2.0. |
Upgrades ESLint in
create-svelte
to v9 and migrates config from.eslintrc.cjs
and.eslintignore
toeslint.config.js
.Closes #10742.
Please don't delete this checklist! Before submitting the PR, please make sure you do the following:
Tests
pnpm test
and lint the project withpnpm lint
andpnpm check
Changesets
pnpm changeset
and following the prompts. Changesets that add features should beminor
and those that fix bugs should bepatch
. Please prefix changeset messages withfeat:
,fix:
, orchore:
.Edits