-
-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: update default playwright test case for lib-project #12261
fix: update default playwright test case for lib-project #12261
Conversation
🦋 Changeset detectedLatest commit: 8a6075f The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Thanks! Can you generate a fix changeset before we merge it? |
I wonder if we need this level of differentiation. Maybe it'd be simpler to just have them both say "Welcome to your new project" or to test some other attribute on the page or something |
Hi thanks for checking the PR! |
You'll need to lint and format the project too. The lint check is currently failing. |
my bad! Formatted the code! |
Thank you! |
Summary
When you create a
Library project
withplaywrite
usingcreate-svelte
, the default test case fails because the content of the H1 in a newLibrary project
is different.Please don't delete this checklist! Before submitting the PR, please make sure you do the following:
Tests
pnpm test
and lint the project withpnpm lint
andpnpm check
Changesets
pnpm changeset
and following the prompts. Changesets that add features should beminor
and those that fix bugs should bepatch
. Please prefix changeset messages withfeat:
,fix:
, orchore:
.Edits