Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: update default playwright test case for lib-project #12261

Merged

Conversation

K-Sato1995
Copy link
Contributor

@K-Sato1995 K-Sato1995 commented May 26, 2024

Summary

When you create a Library project with playwrite using create-svelte, the default test case fails because the content of the H1 in a new Library project is different.


Please don't delete this checklist! Before submitting the PR, please make sure you do the following:

  • It's really useful if your PR references an issue where it is discussed ahead of time. In many cases, features are absent for a reason. For large changes, please create an RFC: https://github.com/sveltejs/rfcs
  • This message body should clearly illustrate what problems it solves.
  • Ideally, include a test that fails without this PR but passes with it.

Tests

  • Run the tests with pnpm test and lint the project with pnpm lint and pnpm check

Changesets

  • If your PR makes a change that should be noted in one or more packages' changelogs, generate a changeset by running pnpm changeset and following the prompts. Changesets that add features should be minor and those that fix bugs should be patch. Please prefix changeset messages with feat:, fix:, or chore:.

Edits

  • Please ensure that 'Allow edits from maintainers' is checked. PRs without this option may be closed.

Copy link

changeset-bot bot commented May 26, 2024

🦋 Changeset detected

Latest commit: 8a6075f

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
create-svelte Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@K-Sato1995 K-Sato1995 changed the title chore: update base playwrite test case for lib-project chore: update default playwright test case for lib-project May 26, 2024
@eltigerchino eltigerchino changed the title chore: update default playwright test case for lib-project fix: update default playwright test case for lib-project May 26, 2024
@eltigerchino
Copy link
Member

Thanks! Can you generate a fix changeset before we merge it?

@benmccann
Copy link
Member

I wonder if we need this level of differentiation. Maybe it'd be simpler to just have them both say "Welcome to your new project" or to test some other attribute on the page or something

@K-Sato1995
Copy link
Contributor Author

@eltigerchino @benmccann

Hi thanks for checking the PR!
Added the changeset but I could also do what @benmccann said.
Open to any suggestions😄

@eltigerchino
Copy link
Member

You'll need to lint and format the project too. The lint check is currently failing.

@K-Sato1995
Copy link
Contributor Author

K-Sato1995 commented May 28, 2024

@eltigerchino

my bad! Formatted the code!
CI / test-kit (18, ubuntu-latest, chromium) (pull_request) has failed for some reason tho.....

@benmccann benmccann merged commit afd227c into sveltejs:main May 28, 2024
10 of 12 checks passed
@github-actions github-actions bot mentioned this pull request May 28, 2024
@eltigerchino
Copy link
Member

Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants