Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: cleanup promise handling #12297

Merged
merged 10 commits into from
Jun 5, 2024
Merged

chore: cleanup promise handling #12297

merged 10 commits into from
Jun 5, 2024

Conversation

Rich-Harris
Copy link
Member

#12284, without all the breaking changes and stuff

there's a cryptic error, i have no idea what this means:

/Users/rich/Development/SVELTE/KIT/kit/packages/adapter-vercel/index.js
  0:0  error  Parsing error: "parserOptions.programs" has been provided for @typescript-eslint/parser.
The file was not found in any of the provided program instance(s): packages/adapter-vercel/index.js

Copy link

changeset-bot bot commented Jun 4, 2024

🦋 Changeset detected

Latest commit: 136e7d4

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@sveltejs/enhanced-img Minor

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@benmccann
Copy link
Member

benmccann commented Jun 5, 2024

there's a cryptic error

That will be fixed by #12280, which should be merged before this PR. I was hoping you or Simon could give it a look to confirm my understanding of the Vercel APIs as I couldn't quite glean from the docs if my change is correct

Copy link
Member

@benmccann benmccann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I added a TODO for a config cleanup I wanted to do and can't figure out

I would still like to understand some of the other rules better, but it seems worth merging this with the less controversial stuff and handling the other ones separately, which should make things easier to discuss

@benmccann benmccann merged commit 8967235 into main Jun 5, 2024
10 of 13 checks passed
@benmccann benmccann deleted the promise-cleanup-2 branch June 5, 2024 21:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants