-
-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: cleanup promise handling #12297
Conversation
🦋 Changeset detectedLatest commit: 136e7d4 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
That will be fixed by #12280, which should be merged before this PR. I was hoping you or Simon could give it a look to confirm my understanding of the Vercel APIs as I couldn't quite glean from the docs if my change is correct |
This reverts commit 596592d.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I added a TODO for a config cleanup I wanted to do and can't figure out
I would still like to understand some of the other rules better, but it seems worth merging this with the less controversial stuff and handling the other ones separately, which should make things easier to discuss
#12284, without all the breaking changes and stuff
there's a cryptic error, i have no idea what this means: