Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: remove noisy output and update text about svelte-add #12337

Merged
merged 2 commits into from
Jun 14, 2024

Conversation

benmccann
Copy link
Member

@benmccann benmccann commented Jun 14, 2024

Rather than telling people about a web page, we should try to help them remember what the command is

It also removes the noisy output, which just buries the info we want people to see. People aren't going to remember those URLs when they want to find the docs. They'll just google it.

Copy link

changeset-bot bot commented Jun 14, 2024

🦋 Changeset detected

Latest commit: 9bdd459

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
create-svelte Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@manuel3108
Copy link
Member

Actually, I think there might be a possibility for a small improvement here.

If a user runs create-svelte in another directory than his cwd (by specifying it in the command line, or by answering the appropriate question) we could directly indicate the user that he needs to do the same for svelte-add by changing the suggested command to

npx svelte-add --path ./user/selected/path

@benmccann
Copy link
Member Author

I honestly didn't know that question existed because I've always run it as npm create svelte myapp. I don't know that I'd necessarily want to print npx svelte-add --path myapp in that case though. It kind of takes away from the snappiness of trying to get people to remember npx svelte-add by making it something that's too long to remember. And we also already print that the next steps should include cp myapp in which case you wouldn't want --path myapp anyway

@benmccann benmccann changed the title chore: update text about svelte-add chore: remove noisy output and update text about svelte-add Jun 14, 2024
@benmccann benmccann merged commit 36b6cf5 into main Jun 14, 2024
11 of 13 checks passed
@benmccann benmccann deleted the svelte-add-create branch June 14, 2024 18:35
@github-actions github-actions bot mentioned this pull request Jun 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants