Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: prevent vitest from hanging #12830

Merged
merged 6 commits into from
Jan 13, 2025
Merged

fix: prevent vitest from hanging #12830

merged 6 commits into from
Jan 13, 2025

Conversation

eltigerchino
Copy link
Member

@eltigerchino eltigerchino commented Oct 18, 2024

fixes #12305
closes #12306

This is an alternative to #12306 . Instead of creating the emulator every time the Vite dev and preview middlewares are invoked, we await Cloudflare's platform proxy only when the adapter emulated platform is accessed, rather than much earlier when adapter.adapt is invoked.

We could still use the newly added test from #12306


Please don't delete this checklist! Before submitting the PR, please make sure you do the following:

  • It's really useful if your PR references an issue where it is discussed ahead of time. In many cases, features are absent for a reason. For large changes, please create an RFC: https://github.com/sveltejs/rfcs
  • This message body should clearly illustrate what problems it solves.
  • Ideally, include a test that fails without this PR but passes with it.

Tests

  • Run the tests with pnpm test and lint the project with pnpm lint and pnpm check

Changesets

  • If your PR makes a change that should be noted in one or more packages' changelogs, generate a changeset by running pnpm changeset and following the prompts. Changesets that add features should be minor and those that fix bugs should be patch. Please prefix changeset messages with feat:, fix:, or chore:.

Edits

  • Please ensure that 'Allow edits from maintainers' is checked. PRs without this option may be closed.

Copy link

changeset-bot bot commented Oct 18, 2024

🦋 Changeset detected

Latest commit: 90b0a86

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@sveltejs/adapter-cloudflare Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@Rich-Harris
Copy link
Member

preview: https://svelte-dev-git-preview-kit-12830-svelte.vercel.app/

this is an automated message

packages/adapter-cloudflare-workers/index.js Outdated Show resolved Hide resolved
packages/adapter-cloudflare/index.js Outdated Show resolved Hide resolved
@dummdidumm dummdidumm merged commit 043cdac into main Jan 13, 2025
5 checks passed
@dummdidumm dummdidumm deleted the fix-cloudflare-vitest branch January 13, 2025 13:36
@github-actions github-actions bot mentioned this pull request Jan 13, 2025
@github-actions github-actions bot mentioned this pull request Jan 27, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

vitest hangs when using adapter-cloudflare
4 participants