fix: support custom servers using HTTP/2 in production

[benmccann]

closes #11365

[changeset-bot]

🦋 Changeset detected

Latest commit: dcefdcf

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package

Name	Type
@sveltejs/kit	Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

[Conduitry]

In #3572, we were able to check the major version of the incoming request and only operate on it then. Is that a possibility here, to avoid doing extra work cloning objects and looking for properties on every incoming request?

[benmccann]

done

I hadn't remembered that we had this before 😆 guess we should have kept it rather than merging #7142. perhaps undici has gotten stricter than it used to be

[eltigerchino]

This was something I tried in the previous PR but ran into some issues with the request URL being set incorrectly during https (#12907 (comment)). Can you verify if this works with HTTPS turned on during dev / preview while navigating around a SvelteKit website?

[Rich-Harris]

preview: https://svelte-dev-git-preview-kit-12989-svelte.vercel.app/

this is an automated message

[benmccann]

It should work now, but please test and let me know if it doesn't

[benmccann]

If we merge #12977 first it might help with testing

[eltigerchino]

LGTM. Managed to reproduce the issue I had earlier where the host was undefined during vite preview with HTTPS. To fix it, I replicated the HTTP2 host assignment logic from the vite/dev/index.js code to vite/preview/index.js.

kit/packages/kit/src/exports/vite/dev/index.js

Line 440 in 7a17bd2

req.headers[':authority'] || req.headers.host

kit/packages/kit/src/exports/vite/preview/index.js

Line 188 in 7a17bd2

const host = req.headers['host'];

[benmccann]

Awesome. Thanks for the help!