Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade to Vite 2.3.3 #1580

Merged
merged 1 commit into from
May 29, 2021
Merged

Upgrade to Vite 2.3.3 #1580

merged 1 commit into from
May 29, 2021

Conversation

benmccann
Copy link
Member

@benmccann benmccann commented May 29, 2021

Only upgrading to 2.3.3 instead of the latest 2.3.4 because the tests fail otherwise

@benmccann benmccann changed the title Upgrade to Vite 2.3.4 Upgrade to Vite 2.3.3 May 29, 2021
@benmccann benmccann merged commit 2172469 into master May 29, 2021
@benmccann benmccann deleted the vite branch May 29, 2021 03:19
sidharthv96 added a commit to sidharthv96/kit that referenced this pull request May 29, 2021
* 'master' of https://github.com/sveltejs/kit:
  Version Packages (next) (sveltejs#1543)
  type fixes for adapter-node and adapter-static (sveltejs#1578)
  Upgrade to Vite 2.3.3 (sveltejs#1580)
  fix: improve getRawBody parsing & handle error(s) (sveltejs#1528)
  create-svelte: add svelte-check for TS (sveltejs#1556)
  pass validated svelte config to adapters (sveltejs#1559)
  types: group related and reduce potential inconsistencies (sveltejs#1539)
  Use sveltekit tag on StackOverflow (sveltejs#1558)
  Fix create-svelte build-template script (sveltejs#1555)
  Remove err param from Polka .listen() callback (sveltejs#1550)
  bump: polka and sirv versions (sveltejs#1548)
  svelte-kit package (sveltejs#1499)
@johnnysprinkles
Copy link
Contributor

I was excited that my change made it into Vite 2.3.5 but now I see SvelteKit won't pick that up, how much work is involved in updating the tests?

@benmccann
Copy link
Member Author

No idea. I didn't try. I don't know if the issue is in the tests or in Vite

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants