Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#166, but javascript #180

Merged
merged 33 commits into from
Nov 26, 2020
Merged
Changes from 1 commit
Commits
Show all changes
33 commits
Select commit Hold shift + click to select a range
57a237e
start work on #166
Rich-Harris Nov 25, 2020
87e60e2
remove typescript
Rich-Harris Nov 25, 2020
c3db751
remove ts-node in favour of esm
Rich-Harris Nov 25, 2020
f2476b3
Build kit package with sucrase
benmccann Nov 25, 2020
2053588
Convert tests to use sucrase
benmccann Nov 25, 2020
4532bd5
javascriptify gh-166
Rich-Harris Nov 25, 2020
cd24731
get build working again
Rich-Harris Nov 25, 2020
d258973
fix gitignore files
Rich-Harris Nov 25, 2020
b13560b
add back some missing files
Rich-Harris Nov 25, 2020
bfed3aa
tidy up
Rich-Harris Nov 25, 2020
5a88c5d
bit more tidying
Rich-Harris Nov 26, 2020
8d561c5
merge liberation -> gh-166-js
Rich-Harris Nov 26, 2020
39e7a94
restrict uvu pattern
Rich-Harris Nov 26, 2020
d5d77c4
copy client files, not everything
Rich-Harris Nov 26, 2020
d4eb980
remove generated file
Rich-Harris Nov 26, 2020
a0b8f61
implement adapter-static using builder API
Rich-Harris Nov 26, 2020
0e78455
ignore generated file
Rich-Harris Nov 26, 2020
4c4f9f6
get svelte-kit-demo example working
Rich-Harris Nov 26, 2020
1712fa8
update lockfile
Rich-Harris Nov 26, 2020
702cf69
add back svelte eslint config peer dependencies
Rich-Harris Nov 26, 2020
47b313e
move render logic into kit
Rich-Harris Nov 26, 2020
92523be
merge master -> gh-166-js
Rich-Harris Nov 26, 2020
83b13f5
update test
Rich-Harris Nov 26, 2020
7f52979
update adapter-netlify
Rich-Harris Nov 26, 2020
b9c0b46
fixes
Rich-Harris Nov 26, 2020
5efcdfc
simplify adapter-netlify
Rich-Harris Nov 26, 2020
e4955c0
use netlify in hn example
Rich-Harris Nov 26, 2020
b9791d5
add use strict pragmas
Rich-Harris Nov 26, 2020
df57dd1
remove unused dependency
Rich-Harris Nov 26, 2020
39f3647
update lockfile
Rich-Harris Nov 26, 2020
46fb674
tidy up
Rich-Harris Nov 26, 2020
6a56c16
update snowpack config
Rich-Harris Nov 26, 2020
e644180
add changeset
Rich-Harris Nov 26, 2020
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
merge master -> gh-166-js
  • Loading branch information
Rich-Harris committed Nov 26, 2020
commit 92523be63940f20ac00dffd08ef7f15383c56f07
29 changes: 29 additions & 0 deletions .github/ISSUE_TEMPLATE.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,29 @@
------
Before filing an issue we'd appreciate it if you could take a moment to ensure
there isn't already an open issue or pull-request.
-----

If there's an existing issue, please add a :+1: reaction to the description of
the issue. One way we prioritize issues is by the number of :+1: reactions on
their descriptions. Please DO NOT add `+1` or :+1: comments.

### Feature requests and proposals
We're excited to hear how we can make SvelteKit better. Please add as much detail
as you can on your use case. To propose an implementation of a large feature or
change, please create an [RFC](https://github.com/sveltejs/rfcs).

### Bugs
If you're filing an issue about a bug please include as much information
as you can, including the following.

- The output of `npx envinfo --system --npmPackages svelte,@sveltejs/kit,@sveltejs/snowpack-config --binaries --browsers`
- Your browser
- Your adapter (e.g. Node, static, Vercel, Begin, etc...)

- *Repeatable steps to reproduce the issue*

* We recommend creating a small repo that illustrates the problem.
* Reproductions should be small, self-contained, correct examples – http://sscce.org.

Thanks for being part of SvelteKit!
-------
52 changes: 52 additions & 0 deletions .github/ISSUE_TEMPLATE/bug_report.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,52 @@
---
name: Bug report
about: Create a report to help us improve
title: ''
labels: 'Bug'
assignees: ''

---

**Describe the bug**
A clear and concise description of what the bug is.

**Logs**
Please include browser console and server logs around the time this bug occurred.

**To Reproduce**
Please make sure you've tested with the latest versions of Svelte and SvelteKit.

To help us help you, if you've found a bug please consider the following:

* If possible, we recommend creating a small repo that illustrates the problem.
* Reproductions should be small, self-contained, correct examples – http://sscce.org.

Occasionally, this won't be possible, and that's fine – we still appreciate you raising the issue. But please understand that Svelte is run by unpaid volunteers in their free time, and issues that follow these instructions will get fixed faster.

**Expected behavior**
A clear and concise description of what you expected to happen.

**Stacktraces**
If you have a stack trace to include, we recommend putting inside a `<details>` block for the sake of the thread's readability:

<details>
<summary>Stack trace</summary>

Stack trace goes here...
</details>

**Information about your SvelteKit Installation:**

- The output of `npx envinfo --system --npmPackages svelte,@sveltejs/kit,@sveltejs/snowpack-config --binaries --browsers`

- Your browser

- Your adapter (e.g. Node, static, Vercel, Begin, etc...)

**Severity**
How severe an issue is this bug to you? Is this annoying, blocking some users, blocking an upgrade or blocking your usage of SvelteKit entirely?

Note: the more honest and specific you are here the more we will take you seriously.

**Additional context**
Add any other context about the problem here.
28 changes: 28 additions & 0 deletions .github/ISSUE_TEMPLATE/feature_request.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,28 @@
---
name: Feature request
about: Suggest an idea for this project
title: ''
labels: 'New Feature'
assignees: ''

---

<!--
If you'd like to propose an implementation for a large new feature or change then please create an RFC:
https://github.com/sveltejs/rfcs
-->

**Is your feature request related to a problem? Please describe.**
A clear and concise description of what the problem is. For example: I'm always frustrated when [...]

**Describe the solution you'd like**
A clear and concise description of what you want to happen.

**Describe alternatives you've considered**
A clear and concise description of any alternative solutions or features you've considered.

**How important is this feature to you?**
Note: the more honest and specific you are here the more we will take you seriously.

**Additional context**
Add any other context or screenshots about the feature request here.
12 changes: 12 additions & 0 deletions .github/ISSUE_TEMPLATE/questions-and-help.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,12 @@
---
name: Questions and help
about: If you think you need help with something related to SvelteKit
title: ''
labels: 'Question'
assignees: ''

---

This issue tracker is intended to collect bug reports and feature requests.

For help with installation, information on how features work, or questions about specific features of SvelteKit, please come and join us in the [Svelte Discord](https://svelte.dev/chat), or ask your question on [Stack Overflow](https://stackoverflow.com/questions/tagged/svelte). Any issues open for help requests will be closed to keep from clogging up the issue tracker.
7 changes: 7 additions & 0 deletions .github/PULL_REQUEST_TEMPLATE.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,7 @@
### Before submitting the PR, please make sure you do the following
- [ ] It's really useful if your PR references an issue where it is discussed ahead of time. In many cases, features are absent for a reason. For large changes, please create an RFC: https://github.com/sveltejs/rfcs
- [ ] This message body should clearly illustrate what problems it solves.
- [ ] Ideally, include a test that fails without this PR but passes with it.

### Tests
- [ ] Run the tests with `npm test` and lint the project with `npm run lint`
4 changes: 2 additions & 2 deletions packages/adapter-node/src/server.js
Original file line number Diff line number Diff line change
@@ -4,8 +4,6 @@ import { parse, URLSearchParams } from 'url';
import sirv from 'sirv';
import { get_body } from '@sveltejs/app-utils/http';

const app = require('./app.js');

const { PORT = 3000 } = process.env;

const mutable = (dir) =>
@@ -24,6 +22,8 @@ const assets_handler = sirv('build/assets', {
immutable: true
});

const app = require('./app.js');

const server = http.createServer((req, res) => {
assets_handler(req, res, () => {
static_handler(req, res, () => {
1 change: 1 addition & 0 deletions packages/kit/.gitignore
Original file line number Diff line number Diff line change
@@ -2,4 +2,5 @@
/node_modules
/dist
/assets/runtime
/assets/renderer
/client/**/*.d.ts
Loading
You are viewing a condensed version of this merge commit. You can view the full changes here.