Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[docs] list packages, link repos & changelogs #2126

Merged
merged 2 commits into from
Aug 7, 2021
Merged

[docs] list packages, link repos & changelogs #2126

merged 2 commits into from
Aug 7, 2021

Conversation

jthegedus
Copy link
Contributor

@jthegedus jthegedus commented Aug 7, 2021 •
edited by benmccann
Loading

Addresses comment from #2116

Tests

NA

Changesets

NA

@changeset-bot
Copy link

changeset-bot bot commented Aug 7, 2021 •
edited
Loading

⚠️ No Changeset found

Latest commit: 282bc20

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@jthegedus
Copy link
Contributor Author

I've no idea why that test failed given the code I changed :/

ignatiusmb
ignatiusmb approved these changes Aug 7, 2021
View reviewed changes
Copy link
Member

@ignatiusmb ignatiusmb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Don't worry about the tests, some of them are flaky. Lint is still passing, so it's fine.

@benmccann benmccann merged commit b136666 into sveltejs:master Aug 7, 2021
@jthegedus jthegedus deleted the patch-1 branch August 8, 2021 01:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ignatiusmb ignatiusmb ignatiusmb approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jthegedus @ignatiusmb @benmccann