-
-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[chore] export App types #2259
[chore] export App types #2259
Conversation
🦋 Changeset detectedLatest commit: 72cfa5f The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
f1778b6
to
0353005
Compare
0353005
to
7bd56c5
Compare
In VSCode, With Esbuild doesn't seem to have a problem resolving |
The Maybe this is the wrong
|
Thanks for taking a look! You're right - that parameter needed to be optional As for my issue using |
I think that exporting
App
will be enough to useinit
andrequest
, but if not we can tweak a bit furtherNOTE: If you open
adapter-node/src/server.js
inmaster
, the import@sveltejs/kit/node
cannot be resolved. I don't understand why. It'd be nice to use these new types in our own adapters, but I can't figure out why they're not available