namespaced kit options #236
Conversation
|
|
|
Renamed |
| export function validate_config(config) { | ||
| for (const key in config) { | ||
| if (!expected.has(key)) { | ||
| warn(`Unexpected option ${key}${key in options ? ` (did you mean kit.${key}?)` : ''}`); |
There was a problem hiding this comment.
Do you think the 'did you mean' here is going to be generally helpful to future users? Singling this out seems to be maybe a bit too focused on people who used Kit before this change, which is practically nobody.
There was a problem hiding this comment.
it's really just there to reduce the number of discord DMs/mentions i/we get in the near term. agree that it doesn't serve much long term purpose
There was a problem hiding this comment.
I somehow had forgotten that there are people out there using it who don't have access to this repo. In light of that, I'd say that yes this warning was a good idea.
See #229 (comment), though maybe should be
kitrather thankitOptions.Would also like to get some validation in here before this gets merged