Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[fix] add explicit types to examples #2657

Merged
merged 7 commits into from
Oct 21, 2021
Merged

Conversation

ignatiusmb
Copy link
Member

Fixes #2636

@changeset-bot
Copy link

changeset-bot bot commented Oct 21, 2021

🦋 Changeset detected

Latest commit: 471c23b

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
create-svelte Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link
Member

@dummdidumm dummdidumm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are other lint errors in form.ts, maybe we should remove them with this PR as well. Something like

//...
: { destroy: () => void } {
	let current_token: unknown;
//..

Copy link
Member

@dummdidumm dummdidumm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

.changeset/poor-cameras-kick.md Outdated Show resolved Hide resolved
Co-authored-by: Simon H <5968653+dummdidumm@users.noreply.github.com>
@ignatiusmb ignatiusmb changed the title [fix] add explicit types to api example [fix] add explicit types to examples Oct 21, 2021
@ignatiusmb ignatiusmb merged commit a575544 into master Oct 21, 2021
@ignatiusmb ignatiusmb deleted the i2636/ts-eslint-api-example branch October 21, 2021 09:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Explicit Return Types on Exported Functions
2 participants