Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[breaking] SSR config object #2669

Closed
wants to merge 14 commits into from

Conversation

JeanJPNM
Copy link
Contributor

Before submitting the PR, please make sure you do the following

  • It's really useful if your PR references an issue where it is discussed ahead of time. In many cases, features are absent for a reason. For large changes, please create an RFC: https://github.com/sveltejs/rfcs
  • This message body should clearly illustrate what problems it solves.
  • Ideally, include a test that fails without this PR but passes with it.

Tests

  • Run the tests with pnpm test and lint the project with pnpm lint and pnpm check

Changesets

  • If your PR makes a change that should be noted in one or more packages' changelogs, generate a changeset by running pnpx changeset and following the prompts. All changesets should be patch until SvelteKit 1.0

Closes #1650 and is an alternative to #2529

@changeset-bot
Copy link

changeset-bot bot commented Oct 23, 2021

🦋 Changeset detected

Latest commit: 88b818a

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@sveltejs/kit Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@dummdidumm
Copy link
Member

If overridable is only there for the top level, then personally I like "never" more as an option. In an ideal world we would be able to do static analysis of the pages and don't need either of these options, but that probably has many edge cases and is very hard to implement, so I really like going with a third option for now.

@benmccann
Copy link
Member

I prefer 'never' as well

@benmccann
Copy link
Member

I'm going to close this in favor of the original PR since that seems to be the preference in order to keep the review queue clean

@benmccann benmccann closed this Oct 23, 2021
@JeanJPNM JeanJPNM deleted the ssr-config-object branch October 23, 2021 18:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Tru-er SPA mode
3 participants