-
-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: address #2815 feedback #2820
Conversation
🦋 Changeset detectedLatest commit: 456a522 The changes in this PR will be included in the next version bump. This PR includes changesets to release 2 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
||
## Bug reporting | ||
|
||
Please make sure the issue you're reporting involves SvelteKit. Many issues related to how a project builds originate from [Vite](https://vitejs.dev/), which SvelteKit uses to build a project. It's important to note that new Vite projects don't use SSR by default and so if you create a new Vite project from scratch many issues won't reproduce eventhough they're caused by Vite. You should thus start with a project that utilizes SSR such as: | ||
Please make sure the issue you're reporting involves SvelteKit. Many issues |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this is all lint/format result
|
||
## Documentation | ||
|
||
Please see [the documentation](https://kit.svelte.dev/docs) for information about getting started and developing with SvelteKit. | ||
Please see [the documentation](https://kit.svelte.dev/docs) for information |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
can you revert the formatting changes? manual line breaks are a pain. if i add a word i need to update every line following. text editors have word wrap to make lines shorter when reading, so there's no need to manually manage it
if you use some automated tool to manage it then it should be checked in and used for all users like prettier and eslint are
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I use zero automation tools. Anything that happened here is a direct result of the command scripts or the stuff that Svelte kit automatically installed into my VS code. Hugely against all of this stuff
"@sveltejs/adapter-cloudflare": patch | ||
--- | ||
|
||
Update READMEs with additional **Comparison** notes |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
don't need a changelog since there are no code changes. I sent a new PR without this file or the formatting changes
Addresses @benmccann's feedback from #2815