-
-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add package command #2882
Add package command #2882
Conversation
🦋 Changeset detectedLatest commit: 2b70f1e The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Or should it be part of |
I agree about worrying that this might be confusing for people who are just writing an app and not a reusable library. I'm not sure what @benmccann's suggesting though. That this become one of the prompts in the |
Also in favor of a prompt "do you want to create a library or an app?" |
I think Disagree that a prompt is appropriate — the whole point of this feature is that apps and libraries are the same thing (an app has an internal library, a library has a demo/docs app, the only difference is which bit is user-facing). If the only thing the prompt changes is whether or not I think the solution here is something I've been meaning to get round to anyway — add some language when
|
👍 Adding that message when the |
Alright, added that. I really think we need to revisit this —
— it's very confusing and shouldn't be necessary. Will open a separate issue though as it will probably mean coordinating with the plugins |
If component libraries are to be a first-class use case for Kit, it stands to reason that
npm run package
should be available in new projects alongsidenpm run build
.Please don't delete this checklist! Before submitting the PR, please make sure you do the following:
Tests
pnpm test
and lint the project withpnpm lint
andpnpm check
Changesets
pnpx changeset
and following the prompts. All changesets should bepatch
until SvelteKit 1.0