Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(amp): update test #3022

Merged
merged 1 commit into from
Dec 11, 2021
Merged

fix(amp): update test #3022

merged 1 commit into from
Dec 11, 2021

Conversation

bluwy
Copy link
Member

@bluwy bluwy commented Dec 11, 2021

Fix amp tests that has been failing in recent PRs. I'm not sure why, but the amp validation for img tags to be in noscript tags isn't happening anymore. amphtml-validator reported a pass (should be a fail). This PR changes the validation test.

I also updated the lock file for action-daploy-docs changes, so it'll reduce diff changes for #3018 and #2986. If this is undesirable I can revert it.

Please don't delete this checklist! Before submitting the PR, please make sure you do the following:

  • It's really useful if your PR references an issue where it is discussed ahead of time. In many cases, features are absent for a reason. For large changes, please create an RFC: https://github.com/sveltejs/rfcs
  • This message body should clearly illustrate what problems it solves.
  • Ideally, include a test that fails without this PR but passes with it.

Tests

  • Run the tests with pnpm test and lint the project with pnpm lint and pnpm check

Changesets

  • If your PR makes a change that should be noted in one or more packages' changelogs, generate a changeset by running pnpx changeset and following the prompts. All changesets should be patch until SvelteKit 1.0

@changeset-bot
Copy link

changeset-bot bot commented Dec 11, 2021

⚠️ No Changeset found

Latest commit: 39b81c3

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@bluwy bluwy merged commit 5a6a2dc into master Dec 11, 2021
@bluwy bluwy deleted the fix-amp-test branch December 11, 2021 14:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants