-
-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[fix] rename BASE
to ORIGIN
and fix config handling
#3423
Conversation
🦋 Changeset detectedLatest commit: 3ded45d The changes in this PR will be included in the next version bump. Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR 💥 An error occurred when fetching the changed packages and changesets in this PR
|
✔️ Deploy Preview for kit-demo canceled. 🔨 Explore the source changes: 3ded45d 🔍 Inspect the deploy log: https://app.netlify.com/sites/kit-demo/deploys/61e969f26b13ca0007a4a6af |
I'm not sure what you're suggesting, but I'm not sure it'd be unpopular. I'm happy to hardcode the environment variable names. I don't know if you were suggesting something else though? |
the rename to origin is a great change! |
I was suggesting there being no default for these environment variables, but that they're still configurable, which would mean you would need to explicitly configure them at build time so that you could specify these values at runtime. |
Ok, then I agree that'd be very unpopular 😆 At least with me |
BASE
to ORIGIN
and fix config handling
This should fix #3420 and fix #3424, but also makes some other changes.
The defaults listed in the readme were out of date, and they have been updated.
This also renamed
BASE
toORIGIN
, per a conversation I had with Rich on Discord.It also adds
'ORIGIN'
as a default value forenv.origin
(previously it wasundefined
), to align with the readme, which indicated that you should be able to just do that without any build-time configuration.I'd like for there to be fewer of these build-time defaults in the adapter config, but I understand that this might not be very popular.
Although the changes are pretty straightforward, this hasn't been properly tested yet. Because of this, and the decision I'd like to come to about the default env/header behavior, I haven't added changesets yet and I am marking this as draft.
Please don't delete this checklist! Before submitting the PR, please make sure you do the following:
Tests
pnpm test
and lint the project withpnpm lint
andpnpm check
Changesets
pnpx changeset
and following the prompts. All changesets should bepatch
until SvelteKit 1.0