Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix initial spa render of 404 errors #3980

Merged
merged 1 commit into from
Feb 17, 2022
Merged

fix initial spa render of 404 errors #3980

merged 1 commit into from
Feb 17, 2022

Conversation

Rich-Harris
Copy link
Member

@Rich-Harris Rich-Harris commented Feb 17, 2022 •
edited
Loading

@changeset-bot
Copy link

changeset-bot bot commented Feb 17, 2022

⚠️ No Changeset found

Latest commit: db16e00

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@Rich-Harris Rich-Harris merged commit eaba628 into sveltejs:gh-3935 Feb 17, 2022
Rich-Harris added a commit that referenced this pull request Feb 17, 2022
@Rich-Harris @mrkishi
Fall back to full page reload if link href doesn't match anything (#3969
11d4a4b 
)

* failing test for #3935

* fall back to full page navigation for unmatched routes - closes #3935

* changeset

* fix initial spa render of 404 errors (#3980)

Co-authored-by: mrkishi <mauriciokishi@gmail.com>

Co-authored-by: mrkishi <mauriciokishi@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Rich-Harris @mrkishi