Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rename app.render to server.respond #4034

Merged
merged 5 commits into from
Feb 21, 2022
Merged
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
fix replacements
Rich-Harris committed Feb 21, 2022
commit 0d74d82be2e693f21c3f767fe78174ec06eba14e
2 changes: 1 addition & 1 deletion packages/adapter-cloudflare-workers/index.js
Original file line number Diff line number Diff line change
@@ -40,7 +40,7 @@ export default function () {

builder.copy(`${files}/entry.js`, `${tmp}/entry.js`, {
replace: {
APP: `${relativePath}/app.js`,
SERVER: `${relativePath}/index.js`,
MANIFEST: './manifest.js'
}
});
2 changes: 1 addition & 1 deletion packages/adapter-netlify/index.js
Original file line number Diff line number Diff line change
@@ -51,7 +51,7 @@ export default function ({ split = false } = {}) {
const redirects = [];

const replace = {
'0APP': './server/app.js' // digit prefix prevents CJS build from using this as a variable name, which would also get replaced
'0SERVER': './server/index.js' // digit prefix prevents CJS build from using this as a variable name, which would also get replaced
};

if (esm) {
2 changes: 1 addition & 1 deletion packages/adapter-node/index.js
Original file line number Diff line number Diff line change
@@ -49,7 +49,7 @@ export default function ({

builder.copy(files, out, {
replace: {
APP: './server/app.js',
SERVER: './server/index.js',
MANIFEST: './manifest.js',
PATH_ENV: JSON.stringify(path_env),
HOST_ENV: JSON.stringify(host_env),
2 changes: 1 addition & 1 deletion packages/adapter-node/rollup.config.js
Original file line number Diff line number Diff line change
@@ -14,6 +14,6 @@ export default [
format: 'esm'
},
plugins: [nodeResolve(), commonjs(), json()],
external: ['APP', 'MANIFEST', ...require('module').builtinModules]
external: ['SERVER', 'MANIFEST', ...require('module').builtinModules]
}
];
2 changes: 1 addition & 1 deletion packages/adapter-vercel/index.js
Original file line number Diff line number Diff line change
@@ -112,7 +112,7 @@ export default function ({ external = [] } = {}) {

builder.copy(files, tmp, {
replace: {
APP: `${relativePath}/app.js`,
SERVER: `${relativePath}/index.js`,
MANIFEST: './manifest.js'
}
});