Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Increase CI test timeout to 20 minutes #4144

Merged
merged 1 commit into from
Feb 27, 2022

Conversation

rmunn
Copy link
Contributor

@rmunn rmunn commented Feb 27, 2022

As discussed in #4123 (comment), the Windows test runs have been slow recently, and several have failed by going over the 15 minute timeout. Others have succeeded but been very close to being timed out, e.g. this run that took 14m54s on Windows (and 12m11s on macOS, but only 6m19s on Ubuntu — apparently the Ubuntu containers are significantly faster than the other two for some reason).

I propose increasing the timeout to 20 minutes rather than 15, to help mitigate the problem of false-positive test failures. It's still low enough that it feels like a reasonable amount of time to wait if a test run has somehow gotten itself into an infinite loop and will never complete, but it should allow the Windows test runners enough time to complete all the tests. As more features are added to Svelte-Kit, or more bugs are fixed and regression tests added, the length of the test runs is only going to go up, so I expect more false-positive test failures in the future unless the timeout is increased.

No changeset since this is just a change to the build process which shouldn't show up in changelogs.

Please don't delete this checklist! Before submitting the PR, please make sure you do the following:

  • It's really useful if your PR references an issue where it is discussed ahead of time. In many cases, features are absent for a reason. For large changes, please create an RFC: https://github.com/sveltejs/rfcs
  • This message body should clearly illustrate what problems it solves.
  • Ideally, include a test that fails without this PR but passes with it.

Tests

  • Run the tests with pnpm test and lint the project with pnpm lint and pnpm check

Changesets

  • If your PR makes a change that should be noted in one or more packages' changelogs, generate a changeset by running pnpx changeset and following the prompts. All changesets should be patch until SvelteKit 1.0

The Windows test runs have been slow recently, and several have failed
by going over the 15 minute timeout. Increasing the timeout to 20 will
help mitigate the problem and reduce false-positive failures.
@changeset-bot
Copy link

changeset-bot bot commented Feb 27, 2022

⚠️ No Changeset found

Latest commit: c4b5e09

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@dominikg dominikg merged commit bad7a48 into sveltejs:master Feb 27, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants