Increase CI test timeout to 20 minutes #4144
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As discussed in #4123 (comment), the Windows test runs have been slow recently, and several have failed by going over the 15 minute timeout. Others have succeeded but been very close to being timed out, e.g. this run that took 14m54s on Windows (and 12m11s on macOS, but only 6m19s on Ubuntu — apparently the Ubuntu containers are significantly faster than the other two for some reason).
I propose increasing the timeout to 20 minutes rather than 15, to help mitigate the problem of false-positive test failures. It's still low enough that it feels like a reasonable amount of time to wait if a test run has somehow gotten itself into an infinite loop and will never complete, but it should allow the Windows test runners enough time to complete all the tests. As more features are added to Svelte-Kit, or more bugs are fixed and regression tests added, the length of the test runs is only going to go up, so I expect more false-positive test failures in the future unless the timeout is increased.
No changeset since this is just a change to the build process which shouldn't show up in changelogs.
Please don't delete this checklist! Before submitting the PR, please make sure you do the following:
Tests
pnpm test
and lint the project withpnpm lint
andpnpm check
Changesets
pnpx changeset
and following the prompts. All changesets should bepatch
until SvelteKit 1.0