Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[docs] highlight need to set trailingSlash with adapter-static #4279

Merged
merged 2 commits into from
Mar 9, 2022
Merged

[docs] highlight need to set trailingSlash with adapter-static #4279

merged 2 commits into from
Mar 9, 2022

Conversation

benmccann
Copy link
Member

Closes #3852

@benmccann benmccann added the documentation Improvements or additions to documentation label Mar 9, 2022
@changeset-bot
Copy link

changeset-bot bot commented Mar 9, 2022 •
edited
Loading

⚠️ No Changeset found

Latest commit: 365de23

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@Conduitry
Copy link
Member

Do we want to add a note about what 'always' does, saying how it writes the file to /a/index.html instead of /a.html? This might be something just for the adapter readme and not the main docs.

@benmccann
Copy link
Member Author

Sure. I've updated it to mention that

Conduitry
Conduitry approved these changes Mar 9, 2022
View reviewed changes
Copy link
Member

@Conduitry Conduitry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@Rich-Harris Rich-Harris merged commit 42cd24f into master Mar 9, 2022
@Rich-Harris Rich-Harris deleted the static-slash-docs branch March 9, 2022 18:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Conduitry Conduitry Conduitry approved these changes

Assignees
No one assigned
Labels
documentation Improvements or additions to documentation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Routing in app built by adapter-static is broken in next.266
3 participants
@benmccann @Conduitry @Rich-Harris