-
-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add cloudflare cache #4412
Merged
Merged
Add cloudflare cache #4412
Changes from 2 commits
Commits
Show all changes
5 commits
Select commit
Hold shift + click to select a range
15bbd79
Add cloudflare cache
johnwalshuk 22a489c
Fix linting issues
johnwalshuk 37da9e4
Update packages/adapter-cloudflare/files/worker.js
johnwalshuk 3722b93
Add check for set-cookie
johnwalshuk f877449
Update packages/adapter-cloudflare/files/worker.js
benmccann File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,5 @@ | ||
--- | ||
'@sveltejs/adapter-cloudflare': patch | ||
--- | ||
|
||
Add cloudflare cache to store responses with a cache header. |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we use
ServiceWorkerGlobalScope
from@cloudflare/workers-types
so that we don't have to@ts-ignore
this?If there's no solution then it should be turned into
@ts-expect-error
along with a comment explaining why it cannot be addressed, but I would hope that it can beThere was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @benmccann, I tried to add the package above but it started to throw ~30 errors in the JS files so for now I've used
@ts-expect-error
with a comment as to why.