Emit types

[Rich-Harris]

So far just app-utils. This fails in weird ways. If running for the first time, this happens:

➜  packages/app-utils git:(emit-types) npx tsc
../../node_modules/.pnpm/@types/node-fetch@2.5.8/node_modules/@types/node-fetch/index.d.ts:18:27 - error TS2792: Cannot find module 'form-data'. Did you mean to set the 'moduleResolution' option to 'node', or to add aliases to the 'paths' option?

18 import FormData = require('form-data');
                             ~~~~~~~~~~~


Found 1 error.

I have no idea what's going on — form-data and node-fetch aren't referenced anywhere inside app-utils. If I run tsc --listFiles and tsc --traceResolution it goes berserk. I have no idea what it thinks it's trying to do.

Run it a second time, and this happens:

➜ packages/app-utils git:(emit-types) npx tsc
error TS5055: Cannot write file '/path/to/kit/packages/app-utils/files/index.d.ts' because it would overwrite input file.

error TS5055: Cannot write file '/path/to/kit/packages/app-utils/http/get_body/index.d.ts' because it would overwrite input file.

error TS5055: Cannot write file '/path/to/kit/packages/app-utils/http/get_body/read_only_form_data.d.ts' because it would overwrite input file.

error TS5055: Cannot write file '/path/to/kit/packages/app-utils/http/index.d.ts' because it would overwrite input file.


Found 4 errors.

I can't figure out how to tell it 'these are files YOU created, you utter dolt, it's okay to overwrite them'. Any tips?

[GrygrFlzr]

I have no idea what's going on — form-data and node-fetch aren't referenced anywhere inside app-utils.

I hunted down the FormData thing and apparently it's this line in @types/node-fetch which imports form-data:

https://github.com/DefinitelyTyped/DefinitelyTyped/blob/a2bf82bb4fa9bd19495102986604ef4c7d8a0cd2/types/node-fetch/index.d.ts#L18

However, the only thing in the monorepo that depends on @types/node-fetch is packages/kit. I'm not sure if it's freaking out with the monorepo layout and trying to build the entire monorepo.

I can't figure out how to tell it 'these are files YOU created, you utter dolt, it's okay to overwrite them'. Any tips?

I fixed it by following its suggestion to use "moduleResolution": "node" and to explicitly specify that the input files must have a .js extension.

[benmccann]

these look like good fixes to me. thanks!

[Rich-Harris]

Man, I could have sworn I tried both those things! Though my globs looked more like "files/**/*.js" than these. Anyway, thanks — will try and get kit emitting types before merging this

[benmccann]

why change this from Router?

[Rich-Harris]

Because the comment still exists once these files have been bundled, but no longer points at anything. If TypeScript were to check that file, because of whatever configuration, it would get confused. Changing it to any doesn't actually impede us in any way, and doesn't affect users because Router and Renderer are a hidden implementation detail