-
-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
typecheck in CI #445
typecheck in CI #445
Conversation
Why is CI not running |
Co-authored-by: Ben McCann <322311+benmccann@users.noreply.github.com>
We might want |
It might be useful to add a TODO above the
|
Would shipping types that require a newer version of TS be considered a breaking change? How do projects under semver generally handle the implied TS peerdep that goes along with their published types? |
I suppose it might be. Probably still worth making a note of it even if we want to hold it for a major release |
I would consider that a breaking change. But it's possible to specify type definitions for certain TS version ranges, which could work if the type is not completely changed, just better typed in a more recent version. |
If we change the type from
to
then it wouldn't break anyone's app, even if they do typechecking, because they would only have been able to return a single |
ah ok i just reread and you're talking about requiring a new TS version, not changing the types. yeah i guess that is a breaking change. still not concerned though because of what @dummdidumm said |
this will fail, but at least it gives us a list of things we need to fix. #441