Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

opt into strict: true in tsconfig.json by default #4516

Closed
wants to merge 1 commit into from
Closed

Conversation

Rich-Harris
Copy link
Member

closes #4395. This is a breaking change

Please don't delete this checklist! Before submitting the PR, please make sure you do the following:

  • It's really useful if your PR references an issue where it is discussed ahead of time. In many cases, features are absent for a reason. For large changes, please create an RFC: https://github.com/sveltejs/rfcs
  • This message body should clearly illustrate what problems it solves.
  • Ideally, include a test that fails without this PR but passes with it.

Tests

  • Run the tests with pnpm test and lint the project with pnpm lint and pnpm check

Changesets

  • If your PR makes a change that should be noted in one or more packages' changelogs, generate a changeset by running pnpx changeset and following the prompts. All changesets should be patch until SvelteKit 1.0

@changeset-bot
Copy link

changeset-bot bot commented Apr 4, 2022

🦋 Changeset detected

Latest commit: 2a32978

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@sveltejs/kit Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@dummdidumm
Copy link
Member

This is closely related to #4495, we should at least release them together to give non-TS users a way to opt out.

The alternative would be to not add strict to the generated tsconfig, and remove checkJs as well. This means we would need to adjust #4495 to add strict accordingly.

@Rich-Harris
Copy link
Member Author

Thinking further on this, it feels like strict probably belongs in the user-editable tsconfig/jsconfig, rather than the one we extend from. There's a few other compiler options I'd put in the same category

@dummdidumm
Copy link
Member

Agree. I'd move the following to the user config:
skipLibCheck, esModuleInterop (honestly not even sure if it works for Svelte files since TS can't see the other files during transpiration)

The following I'm not sure about:
resolveJsonModule (if user doesn't have a declare module "*.json" somewhere they would get errors)

@Rich-Harris
Copy link
Member Author

I don't think Kit or the default apps rely on resolveJsonModule though? Feels like that belongs to user config too

@Rich-Harris
Copy link
Member Author

Closing this in favour of #4633, which documents the generated tsconfig and moves non-essential stuff into user config, where it can be changed freely

@Rich-Harris Rich-Harris deleted the gh-4395 branch April 22, 2022 16:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Make strict mode the default when choosing Typescript
2 participants