Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

create-svelte: Make hooks file comply with TypeScript strictest mode #4667

Merged
merged 1 commit into from
Apr 20, 2022
Merged

create-svelte: Make hooks file comply with TypeScript strictest mode #4667

merged 1 commit into from
Apr 20, 2022

Conversation

KuSh
Copy link
Contributor

@KuSh KuSh commented Apr 20, 2022

Fixes:

  • Error: Module '@types/cookie/index' has no default export. ts(1192)
  • Error: Property 'userid' comes from an index signature, so it must be accessed with ['userid']. ts(4111)

Strictest tsconfig from https://github.com/tsconfig/bases/blob/27f9097a02f960e351d69bca8dd4c7581d70e1b6/bases/strictest.json

Please don't delete this checklist! Before submitting the PR, please make sure you do the following:

  • It's really useful if your PR references an issue where it is discussed ahead of time. In many cases, features are absent for a reason. For large changes, please create an RFC: https://github.com/sveltejs/rfcs
  • This message body should clearly illustrate what problems it solves.
  • Ideally, include a test that fails without this PR but passes with it.

Tests

  • Run the tests with pnpm test and lint the project with pnpm lint and pnpm check

Changesets

  • If your PR makes a change that should be noted in one or more packages' changelogs, generate a changeset by running pnpx changeset and following the prompts. All changesets should be patch until SvelteKit 1.0

Error: Module '@types/cookie/index' has no default export. ts(1192)
Error: Property 'userid' comes from an index signature, so it must be accessed with ['userid']. ts(4111)

Strictest tsconfig from https://github.com/tsconfig/bases/blob/27f9097a02f960e351d69bca8dd4c7581d70e1b6/bases/strictest.json
@changeset-bot
Copy link

changeset-bot bot commented Apr 20, 2022

🦋 Changeset detected

Latest commit: 3b2bce2

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
create-svelte Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@Rich-Harris Rich-Harris merged commit d723e87 into sveltejs:master Apr 20, 2022
@Rich-Harris
Copy link
Member

thanks!

@KuSh KuSh deleted the fix/hooks-tsc-errors-in-strict-mode branch April 21, 2022 06:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants