Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Upgrade page caching #4690

Conversation

elliott-with-the-longest-name-on-github
Copy link
Contributor

Please don't delete this checklist! Before submitting the PR, please make sure you do the following:

  • It's really useful if your PR references an issue where it is discussed ahead of time. In many cases, features are absent for a reason. For large changes, please create an RFC: https://github.com/sveltejs/rfcs
  • This message body should clearly illustrate what problems it solves.
  • Ideally, include a test that fails without this PR but passes with it.

Tests

  • Run the tests with pnpm test and lint the project with pnpm lint and pnpm check

Changesets

  • If your PR makes a change that should be noted in one or more packages' changelogs, generate a changeset by running pnpx changeset and following the prompts. All changesets should be patch until SvelteKit 1.0

This completes #4549. A couple of notes for consideration before merging:

The cache.private option will override (perhaps confusingly?) behavior that's currently in place -- for example, cache.private === false will cause the cache-control header to be public, even if a credentialed fetch or the session object is accessed (whether in init or in load). Because of this, I was extra specific in the tests, asserting that the override worked in every case. Even if this is a bit confusing at first, I can't think that going half way (having it not override the defaults) in some cases would be any clearer.

@changeset-bot
Copy link

changeset-bot bot commented Apr 22, 2022

🦋 Changeset detected

Latest commit: fa7a5ce

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@sveltejs/kit Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@elliott-with-the-longest-name-on-github
Copy link
Contributor Author

Note: Cannot replicate test failure locally. ☹️

@Rich-Harris Rich-Harris merged commit 588a01b into sveltejs:master Apr 22, 2022
@Rich-Harris
Copy link
Member

thank you, this is a great PR!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants