Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[chore] remove env GH action and browser caching #4728

Merged
merged 7 commits into from
Apr 25, 2022

Conversation

Conduitry
Copy link
Member

.github/actions/env has been bugging me for a while. We had built code that needed to be checked in - and which apparently hadn't been kept up to date in a while, because whenever I ran pnpm build locally, it changed this file.

We'll see what happens when CI runs, but this attempts to replace that whole file with a re-creation of just the functionality we need, which lets us drop the build process for the file and remove the whole @actions/core dependency.

Please don't delete this checklist! Before submitting the PR, please make sure you do the following:

  • It's really useful if your PR references an issue where it is discussed ahead of time. In many cases, features are absent for a reason. For large changes, please create an RFC: https://github.com/sveltejs/rfcs
  • This message body should clearly illustrate what problems it solves.
  • Ideally, include a test that fails without this PR but passes with it.

Tests

  • Run the tests with pnpm test and lint the project with pnpm lint and pnpm check

Changesets

  • If your PR makes a change that should be noted in one or more packages' changelogs, generate a changeset by running pnpx changeset and following the prompts. All changesets should be patch until SvelteKit 1.0

@changeset-bot
Copy link

changeset-bot bot commented Apr 25, 2022

⚠️ No Changeset found

Latest commit: fbe3d34

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@Conduitry
Copy link
Member Author

Conduitry commented Apr 25, 2022

After #4727 is resolved, I'll merge master back in here and we'll see what happens.

@Conduitry Conduitry changed the title [chore] simplify env GH action [chore] remove env GH action and browser caching Apr 25, 2022
@Conduitry
Copy link
Member Author

This now removes the env action entirely. pnpm caching was getting handled another way now, and the Playwright browser caching was of limited value.

@Conduitry Conduitry merged commit f765738 into sveltejs:master Apr 25, 2022
@Conduitry Conduitry deleted the simplify-env-action branch April 25, 2022 13:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants