Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bind all network interfaces on preview --host #4729

Merged
merged 3 commits into from
Apr 25, 2022
Merged

bind all network interfaces on preview --host #4729

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
35764ef
bind all network interfaces on `preview --host`
mrkishi Apr 25, 2022
ca748a0
add changeset
mrkishi Apr 25, 2022
fad0bef
Merge branch 'master' into preview-host
mrkishi Apr 25, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions .changeset/shiny-birds-ring.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
'@sveltejs/kit': patch
---

[breaking] Supplying an empty `--host` option to `preview` exposes the server to both ipv4 and ipv6 networks
2 changes: 1 addition & 1 deletion packages/kit/src/core/preview/index.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -161,7 +161,7 @@ export async function preview({ port, host, config, https: use_https = false })
});

return new Promise((fulfil) => {
http_server.listen(port, host || '0.0.0.0', () => {
http_server.listen(port, host, () => {
fulfil(http_server);
});
});
Expand Down