Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update tsconfig docs #4826

Merged
merged 4 commits into from
May 5, 2022
Merged

Update tsconfig docs #4826

merged 4 commits into from
May 5, 2022

Conversation

ghostdevv
Copy link
Member

Please don't delete this checklist! Before submitting the PR, please make sure you do the following:

  • It's really useful if your PR references an issue where it is discussed ahead of time. In many cases, features are absent for a reason. For large changes, please create an RFC: https://github.com/sveltejs/rfcs
  • This message body should clearly illustrate what problems it solves.
  • Ideally, include a test that fails without this PR but passes with it.

Tests

  • Run the tests with pnpm test and lint the project with pnpm lint and pnpm check

Changesets

  • If your PR makes a change that should be noted in one or more packages' changelogs, generate a changeset by running pnpx changeset and following the prompts. All changesets should be patch until SvelteKit 1.0

Forgot to change this in #4791

@changeset-bot
Copy link

changeset-bot bot commented May 4, 2022

⚠️ No Changeset found

Latest commit: a0e0583

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@benmccann benmccann added documentation Improvements or additions to documentation types / typescript labels May 5, 2022
Copy link
Member

@Rich-Harris Rich-Harris left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, though I think this probably belong in the 'Others are required for SvelteKit to work properly' section rather than the 'generated programmatically based on your project configuration' section?

@ghostdevv
Copy link
Member Author

I went back and forth on that quite a bit, if you think it does then I am all for it - SvelteKit works fine without it but the packaging will break unless you specifically change things

@ghostdevv
Copy link
Member Author

Updated

Co-authored-by: Ben McCann <322311+benmccann@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation types / typescript
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants